Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1128523003: Add support for passing errors through PopulateArrayFromList. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for passing errors through PopulateArrayFromList. When a JSON schema includes an array of objects PopulateArrayFromList calls a specialized PopulateItem instance for the generated object type. When compiled with generate_error_messages=True the generated type's Populate method expects to receive an error parameter. This patch adds versions of the PopulateArrayFromList and PopulateItem functions that pass through and provide that parameter. This capability is required for a new manifest key that will include an array of objects being added as part of issue 468955. Committed: https://crrev.com/89a17f7839bfedeee84ae1dbc178fb13dfe03eba Cr-Commit-Position: refs/heads/master@{#328471}

Patch Set 1 #

Patch Set 2 : Updated JSON schema tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -15 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/test/error_generation_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/util.h View 4 chunks +62 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 4 chunks +90 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/util_cc_helper.py View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 7 months ago (2015-05-05 22:17:24 UTC) #2
Ken Rockot(use gerrit already)
lgtm but here is a proposal: could you make the error-string-aware implementations safely handle nullptrs, ...
5 years, 7 months ago (2015-05-05 22:24:31 UTC) #3
Reilly Grant (use Gerrit)
On 2015/05/05 22:24:31, Ken Rockot wrote: > lgtm but here is a proposal: > > ...
5 years, 7 months ago (2015-05-05 22:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128523003/1
5 years, 7 months ago (2015-05-05 22:49:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128523003/20001
5 years, 7 months ago (2015-05-06 01:28:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 02:34:42 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 02:35:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89a17f7839bfedeee84ae1dbc178fb13dfe03eba
Cr-Commit-Position: refs/heads/master@{#328471}

Powered by Google App Engine
This is Rietveld 408576698