Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1128513002: Remove unnecessary ternaries to improve readability. (Closed)

Created:
5 years, 7 months ago by Thiemo Nagel
Modified:
5 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ternaries to improve readability. BUG=None Committed: https://crrev.com/d358dccf326b51d60b72292bae9f73cdd1475bcf Cr-Commit-Position: refs/heads/master@{#328388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/logging.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Thiemo Nagel
Hi Dana, could you please take a look at this split-off from the other CL? ...
5 years, 7 months ago (2015-05-05 09:34:37 UTC) #2
danakj
LGTM
5 years, 7 months ago (2015-05-05 17:37:36 UTC) #3
Thiemo Nagel
On 2015/05/05 17:37:36, danakj wrote: > LGTM Thanks a lot!
5 years, 7 months ago (2015-05-05 18:02:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128513002/1
5 years, 7 months ago (2015-05-05 18:03:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 20:00:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d358dccf326b51d60b72292bae9f73cdd1475bcf Cr-Commit-Position: refs/heads/master@{#328388}
5 years, 7 months ago (2015-05-05 20:02:44 UTC) #8
piman
5 years, 7 months ago (2015-05-05 20:23:03 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1127593004/ by piman@chromium.org.

The reason for reverting is: Compile errors -
http://build.chromium.org/p/chromium/buildstatus?builder=Win&number=31603.

Powered by Google App Engine
This is Rietveld 408576698