Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: content/common/mojo/service_registry_impl.h

Issue 1128493002: Add connection error handing in ServiceRegistryImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/mojo/service_registry_impl.h
diff --git a/content/common/mojo/service_registry_impl.h b/content/common/mojo/service_registry_impl.h
index 13aba813f6bb19033f065b3a02ca532c0965bab9..7ffaa77d446bd34984c9a6f1b6c828ca898f0a99 100644
--- a/content/common/mojo/service_registry_impl.h
+++ b/content/common/mojo/service_registry_impl.h
@@ -15,6 +15,7 @@
#include "base/memory/weak_ptr.h"
#include "content/public/common/service_registry.h"
#include "third_party/mojo/src/mojo/public/cpp/bindings/binding.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h"
#include "third_party/mojo/src/mojo/public/cpp/system/core.h"
#include "third_party/mojo/src/mojo/public/interfaces/application/service_provider.mojom.h"
@@ -22,7 +23,8 @@ namespace content {
class CONTENT_EXPORT ServiceRegistryImpl
: public ServiceRegistry,
- public NON_EXPORTED_BASE(mojo::ServiceProvider) {
+ public NON_EXPORTED_BASE(mojo::ServiceProvider),
+ public NON_EXPORTED_BASE(mojo::ErrorHandler) {
public:
ServiceRegistryImpl();
~ServiceRegistryImpl() override;
@@ -44,6 +46,8 @@ class CONTENT_EXPORT ServiceRegistryImpl
void ConnectToRemoteService(const base::StringPiece& service_name,
mojo::ScopedMessagePipeHandle handle) override;
+ bool IsBound() const;
+
base::WeakPtr<ServiceRegistry> GetWeakPtr();
private:
@@ -51,6 +55,9 @@ class CONTENT_EXPORT ServiceRegistryImpl
void ConnectToService(const mojo::String& name,
mojo::ScopedMessagePipeHandle client_handle) override;
+ // mojo::ErrorHandler overrides.
+ void OnConnectionError() override;
+
mojo::Binding<mojo::ServiceProvider> binding_;
mojo::ServiceProviderPtr remote_provider_;
« no previous file with comments | « no previous file | content/common/mojo/service_registry_impl.cc » ('j') | content/common/mojo/service_registry_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698