Add connection error handing in ServiceRegistryImpl.

Add connection error handing in ServiceRegistryImpl.

This will be useful when hosting mojo services in the utility process where the process can go away after being idle for a certain period of time. When that happens, the ServiceRegistryImpl will not be bound and needs to be reconnected before it can be used again. For background, please see http://goo.gl/sMpZ0g.

BUG=479935
TEST=Tested by manually killing the process hosting the other side of the ServiceRegistryImpl.

Committed: https://crrev.com/a3140a9f83f0aa1c2ee4b7bf1a5b9dd8f127496d
Cr-Commit-Position: refs/heads/master@{#330946}

[xhwang, 2015-05-05 06:06:28]

xhwang@chromium.org changed reviewers:
+ rockot@chromium.org

[xhwang, 2015-05-05 06:06:28]

PTAL

[Ken Rockot(use gerrit already), 2015-05-05 17:59:23]

LGTM.

FYI I'm trying to figure out what it would look like to embed a Mojo shell in
the browser and let arbitrary Mojo apps be hooked up to it. This would obviate
the need for a ServiceRegistry in the utility process altogether. WIP CL:
https://codereview.chromium.org/1128453004/

https://codereview.chromium.org/1128493002/diff/1/content/common/mojo/service...
File content/common/mojo/service_registry_impl.cc (right):

https://codereview.chromium.org/1128493002/diff/1/content/common/mojo/service...
content/common/mojo/service_registry_impl.cc:24:
binding_.set_error_handler(this);
nit: might as well just do this in the ctor

[xhwang, 2015-05-05 18:08:07]

> FYI I'm trying to figure out what it would look like to embed a Mojo shell in
> the browser and let arbitrary Mojo apps be hooked up to it. This would obviate
> the need for a ServiceRegistry in the utility process altogether. WIP CL:
> https://codereview.chromium.org/1128453004/

Thanks for the heads-up. By "arbitrary Mojo apps", do you mean something like
media.mojo that we use with html_viewer? Is there a doc about this change?

[xhwang, 2015-05-05 18:08:27]

comments addressed

[xhwang, 2015-05-05 18:09:26]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2015-05-05 18:09:26]

jam: Please OWNERS review.

https://codereview.chromium.org/1128493002/diff/1/content/common/mojo/service...
File content/common/mojo/service_registry_impl.cc (right):

https://codereview.chromium.org/1128493002/diff/1/content/common/mojo/service...
content/common/mojo/service_registry_impl.cc:24:
binding_.set_error_handler(this);
On 2015/05/05 17:59:23, Ken Rockot wrote:
> nit: might as well just do this in the ctor

Done.

[jam, 2015-05-07 16:45:01]

lgtm, sorry for the delay

[xhwang, 2015-05-07 16:46:02]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-05-07 16:46:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1128493002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2015-05-07 16:48:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128493002/20001

[commit-bot: I haz the power, 2015-05-07 17:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 17:43:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2015-05-07 18:06:39]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-05-07 18:08:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128493002/20001

[commit-bot: I haz the power, 2015-05-07 19:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 19:21:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2015-05-08 17:50:29]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-05-08 17:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128493002/20001

[commit-bot: I haz the power, 2015-05-08 19:46:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-08 19:46:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2015-05-08 19:50:59]

On 2015/05/08 19:46:30, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like you're running into an IPC bug that went undetected for a while.

Fix is here waiting for review: https://codereview.chromium.org/1130413002/

[xhwang, 2015-05-08 20:10:37]

On 2015/05/08 19:50:59, Ken Rockot wrote:
> On 2015/05/08 19:46:30, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Looks like you're running into an IPC bug that went undetected for a while.
> 
> Fix is here waiting for review: https://codereview.chromium.org/1130413002/

Cool. Thanks for digging into this!

[xhwang, 2015-05-13 05:20:05]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-05-13 05:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128493002/20001

[commit-bot: I haz the power, 2015-05-13 06:13:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 06:13:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2015-05-21 05:03:40]

rebase only

[xhwang, 2015-05-21 17:27:23]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-05-21 17:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1128493002/#ps40001
(title: "rebase only")

[commit-bot: I haz the power, 2015-05-21 17:27:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128493002/40001

[commit-bot: I haz the power, 2015-05-21 17:32:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-21 17:33:26]

Patchset 3 (id:??) landed as
https://crrev.com/a3140a9f83f0aa1c2ee4b7bf1a5b9dd8f127496d
Cr-Commit-Position: refs/heads/master@{#330946}