Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1128473003: In PatchIssue, add CL description to commit message (Closed)

Created:
5 years, 7 months ago by wychen
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

In PatchIssue, add CL description to commit message Before this change, the commit message only contains issue number and patchset number. Adding CL description should be more informative. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M git_cl.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/git_cl_test.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
wychen
PTAL. Just make the local commit message more informative.
5 years, 7 months ago (2015-05-05 18:15:39 UTC) #2
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-05 18:23:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128473003/1
5 years, 7 months ago (2015-05-08 16:07:53 UTC) #5
commit-bot: I haz the power
Dry run: Presubmit check for 1128473003-1 failed and returned exit status 1. Running presubmit commit ...
5 years, 7 months ago (2015-05-08 16:10:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128473003/1
5 years, 6 months ago (2015-05-28 21:39:02 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 21:41:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295449

Powered by Google App Engine
This is Rietveld 408576698