components/printing/renderer/print_web_view_helper.cc - Issue 1128453003: Remove the OOP PDF flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 1128453003: Remove the OOP PDF flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index cef7a95b85e3ff2e799b957edfb7af80d6526384..97c0a96a3771bba32636309ca5dd10370c810241 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -904,8 +904,7 @@ void PrintWebViewHelper::OnPrintForPrintPreview(

// the element with ID "pdf-viewer" if it isn't an iframe.

blink::WebLocalFrame* plugin_frame = pdf_element.document().frame();

blink::WebElement plugin_element = pdf_element;

- if (delegate_->IsOutOfProcessPdfEnabled() &&

- pdf_element.hasHTMLTagName("iframe")) {

+ if (pdf_element.hasHTMLTagName("iframe")) {

plugin_frame = blink::WebLocalFrame::fromFrameOwnerElement(pdf_element);

plugin_element = delegate_->GetPdfElement(plugin_frame);

if (plugin_element.isNull()) {