Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1128453003: Remove the OOP PDF flag (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the OOP PDF flag This removes the flag for enabling OOP PDF since it is enabled by default and the in process viewer no longer works anyway. The old in-process browser tests have been removed. They are mostly replaced by pdf_extension_test.cc and they are disabled anyway. BUG=483870, 436444 Committed: https://crrev.com/be67c3d1a41734b948b91cb0b7d57a0ecb6ef389 Cr-Commit-Position: refs/heads/master@{#328687}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -604 lines) Patch
M android_webview/renderer/aw_print_web_view_helper_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/renderer/aw_print_web_view_helper_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_browsertest_base.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_browsertest_base.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_interactive_browsertest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/printing/test/print_test_content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
raymes
5 years, 7 months ago (2015-05-05 01:13:34 UTC) #2
Sam McNally
LGTM https://codereview.chromium.org/1128453003/diff/1/chrome/browser/pdf/pdf_extension_test.cc File chrome/browser/pdf/pdf_extension_test.cc (right): https://codereview.chromium.org/1128453003/diff/1/chrome/browser/pdf/pdf_extension_test.cc#newcode28 chrome/browser/pdf/pdf_extension_test.cc:28: void SetUpCommandLine(base::CommandLine* command_line) override { Remove.
5 years, 7 months ago (2015-05-05 01:22:31 UTC) #3
raymes
+thestig@ https://codereview.chromium.org/1128453003/diff/1/chrome/browser/pdf/pdf_extension_test.cc File chrome/browser/pdf/pdf_extension_test.cc (right): https://codereview.chromium.org/1128453003/diff/1/chrome/browser/pdf/pdf_extension_test.cc#newcode28 chrome/browser/pdf/pdf_extension_test.cc:28: void SetUpCommandLine(base::CommandLine* command_line) override { On 2015/05/05 01:22:31, ...
5 years, 7 months ago (2015-05-05 01:26:19 UTC) #5
Lei Zhang
lgtm, remember to delete the pdf_private directory at some point.
5 years, 7 months ago (2015-05-05 01:36:24 UTC) #6
raymes
That directory is now used by pdf_extension_test :)
5 years, 7 months ago (2015-05-05 02:11:36 UTC) #7
raymes
+mnaganov for android_webview
5 years, 7 months ago (2015-05-05 02:12:22 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128453003/20001
5 years, 7 months ago (2015-05-05 04:10:03 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 05:25:27 UTC) #14
raymes
mnaganov: friendly ping in case you missed this :)
5 years, 7 months ago (2015-05-05 23:41:29 UTC) #15
mnaganov (inactive)
Apologies for the delay! android_webview/ LGTM
5 years, 7 months ago (2015-05-06 15:55:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128453003/20001
5 years, 7 months ago (2015-05-06 23:29:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 02:45:17 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 02:46:14 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be67c3d1a41734b948b91cb0b7d57a0ecb6ef389
Cr-Commit-Position: refs/heads/master@{#328687}

Powered by Google App Engine
This is Rietveld 408576698