Add linter by default for polymer's pub-build, also cleans up the linter code.

Add linter by default for polymer's pub-build, also cleans up the linter code.
Now that barback support listening for log messages, we can remove the logging
hooks we temporarily added in our linter.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31110

[Siggi Cherem (dart-lang), 2013-12-12 03:14:55]

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/build_filter.dart (right):

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/build_filter.dart:48: String toString() =>
'polymer-build-filter';
this is used by pub-build to indicate which transformer produced an
error/warning message.

[Jennifer Messerly, 2013-12-12 03:32:55]

lgtm

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/build_filter.dart (right):

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/build_filter.dart:48: String toString() =>
'polymer-build-filter';
On 2013/12/12 03:14:55, Siggi Cherem (dart-lang) wrote:
> this is used by pub-build to indicate which transformer produced an
> error/warning message.

nice!

My only question: should this just be '$runtimeType'? that way if we rename the
type the toString is updated for free. (and make the type called
'PolymerBuildFilter')

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/linter.dart (left):

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/linter.dart:135: class _LoggerInterceptor implements
Transform, TransformLogger {
awesome to see this go

[Siggi Cherem (dart-lang), 2013-12-12 17:57:27]

thanks

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/build_filter.dart (right):

https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/build_filter.dart:48: String toString() =>
'polymer-build-filter';
On 2013/12/12 03:32:55, John Messerly wrote:
> On 2013/12/12 03:14:55, Siggi Cherem (dart-lang) wrote:
> > this is used by pub-build to indicate which transformer produced an
> > error/warning message.
> 
> nice!
> 
> My only question: should this just be '$runtimeType'? that way if we rename
the
> type the toString is updated for free. (and make the type called
> 'PolymerBuildFilter')
> 

haha - that's the default behavior from pub if you don't define 'toString'. But
I overwrote this to make it more user readable :-).

I prefer not to prefix every type just because it has a nicer print
representation, we can also just add "Polymer" in the toString.

The current messages look like this:

  [Warning in polymer-linter on sample|web/index.html]: ...
  [Warning in polymer-import-inliner on sample|web/index.html]: ...

Some other ideas:
- "Polymer$runtimeType"
  [Warning in PolymerLinter on sample|web/index.html]: ...
  [Warning in PolymerImportInliner on sample|web/index.html]: ...

- "polymer ($runtimeType)"
  [Warning in polymer (Linter) on sample|web/index.html]: ...
  [Warning in polymer (ImportInliner) on sample|web/index.html]: ...

I'm starting to like the last one the best. I just updated the CL to use that,
but will wait for your thoughts.

[Jennifer Messerly, 2013-12-12 19:26:36]

On 2013/12/12 17:57:27, Siggi Cherem (dart-lang) wrote:
> thanks
> 
>
https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
> File pkg/polymer/lib/src/build/build_filter.dart (right):
> 
>
https://codereview.chromium.org/112843004/diff/20001/pkg/polymer/lib/src/buil...
> pkg/polymer/lib/src/build/build_filter.dart:48: String toString() =>
> 'polymer-build-filter';
> On 2013/12/12 03:32:55, John Messerly wrote:
> > On 2013/12/12 03:14:55, Siggi Cherem (dart-lang) wrote:
> > > this is used by pub-build to indicate which transformer produced an
> > > error/warning message.
> > 
> > nice!
> > 
> > My only question: should this just be '$runtimeType'? that way if we rename
> the
> > type the toString is updated for free. (and make the type called
> > 'PolymerBuildFilter')
> > 
> 
> haha - that's the default behavior from pub if you don't define 'toString'.
But
> I overwrote this to make it more user readable :-).
> 
> I prefer not to prefix every type just because it has a nicer print
> representation, we can also just add "Polymer" in the toString.
> 
> The current messages look like this:
> 
>   [Warning in polymer-linter on sample|web/index.html]: ...
>   [Warning in polymer-import-inliner on sample|web/index.html]: ...
> 
> Some other ideas:
> - "Polymer$runtimeType"
>   [Warning in PolymerLinter on sample|web/index.html]: ...
>   [Warning in PolymerImportInliner on sample|web/index.html]: ...
> 
> - "polymer ($runtimeType)"
>   [Warning in polymer (Linter) on sample|web/index.html]: ...
>   [Warning in polymer (ImportInliner) on sample|web/index.html]: ...
> 
> I'm starting to like the last one the best. I just updated the CL to use that,
> but will wait for your thoughts.

Nice! +1

[Siggi Cherem (dart-lang), 2013-12-12 21:04:27]

Committed patchset #3 manually as r31110 (presubmit successful).