Source/core/dom/DOMTokenList.h - Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMTokenList.h

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMTokenList.h

diff --git a/Source/core/dom/DOMTokenList.h b/Source/core/dom/DOMTokenList.h

index d758214d09a94386619bc627fddf7387ee138010..bdaf34de64418a2ed14dd49cf2883851a2eff5f5 100644

--- a/Source/core/dom/DOMTokenList.h

+++ b/Source/core/dom/DOMTokenList.h

@@ -69,12 +69,12 @@ protected:

virtual bool containsInternal(const AtomicString&) const = 0;

virtual void removeInternal(const AtomicString&);

- static bool validateToken(const AtomicString&, ExceptionState&);

+ static bool validateToken(const String&, ExceptionState&);

static bool validateTokens(const Vector<String>&, ExceptionState&);

- static String addToken(const AtomicString&, const AtomicString&);

- static String addTokens(const AtomicString&, const Vector<String>&);

- static String removeToken(const AtomicString&, const AtomicString&);

- static String removeTokens(const AtomicString&, const Vector<String>&);

+ static AtomicString addToken(const AtomicString&, const AtomicString&);

+ static AtomicString addTokens(const AtomicString&, const Vector<String>&);

+ static AtomicString removeToken(const AtomicString&, const AtomicString&);

+ static AtomicString removeTokens(const AtomicString&, const Vector<String>&);

};

} // namespace WebCore

« no previous file with comments | « Source/core/dom/DOMSettableTokenList.cpp ('k') | Source/core/dom/DOMTokenList.cpp » ('j') | Source/core/dom/NamedFlowCollection.cpp » ('J')