Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2792 matching lines...) Expand 10 before | Expand all | Expand 10 after
2803 return 0; 2803 return 0;
2804 } 2804 }
2805 2805
2806 bool Element::webkitMatchesSelector(const String& selector, ExceptionState& exce ptionState) 2806 bool Element::webkitMatchesSelector(const String& selector, ExceptionState& exce ptionState)
2807 { 2807 {
2808 if (selector.isEmpty()) { 2808 if (selector.isEmpty()) {
2809 exceptionState.throwDOMException(SyntaxError, "The selector provided is empty."); 2809 exceptionState.throwDOMException(SyntaxError, "The selector provided is empty.");
2810 return false; 2810 return false;
2811 } 2811 }
2812 2812
2813 SelectorQuery* selectorQuery = document().selectorQueryCache().add(selector, document(), exceptionState); 2813 SelectorQuery* selectorQuery = document().selectorQueryCache().add(AtomicStr ing(selector), document(), exceptionState);
2814 if (!selectorQuery) 2814 if (!selectorQuery)
2815 return false; 2815 return false;
2816 return selectorQuery->matches(*this); 2816 return selectorQuery->matches(*this);
2817 } 2817 }
2818 2818
2819 DOMTokenList* Element::classList() 2819 DOMTokenList* Element::classList()
2820 { 2820 {
2821 ElementRareData& rareData = ensureElementRareData(); 2821 ElementRareData& rareData = ensureElementRareData();
2822 if (!rareData.classList()) 2822 if (!rareData.classList())
2823 rareData.setClassList(ClassList::create(this)); 2823 rareData.setClassList(ClassList::create(this));
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
3655 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3655 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3656 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3656 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3657 if (hasTagName(optionTag) || hasTagName(optgroupTag)) 3657 if (hasTagName(optionTag) || hasTagName(optgroupTag))
3658 return false; 3658 return false;
3659 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3659 if (FullscreenElementStack::isActiveFullScreenElement(this))
3660 return false; 3660 return false;
3661 return true; 3661 return true;
3662 } 3662 }
3663 3663
3664 } // namespace WebCore 3664 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698