Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
868 return 0; 868 return 0;
869 newElement->appendChild(newChild.release(), exceptionState); 869 newElement->appendChild(newChild.release(), exceptionState);
870 if (exceptionState.hadException()) 870 if (exceptionState.hadException())
871 return 0; 871 return 0;
872 } 872 }
873 } 873 }
874 874
875 return newElement.release(); 875 return newElement.release();
876 } 876 }
877 case ATTRIBUTE_NODE: 877 case ATTRIBUTE_NODE:
878 return Attr::create(*this, QualifiedName(nullAtom, toAttr(importedNode)- >name(), nullAtom), toAttr(importedNode)->value()); 878 return Attr::create(*this, QualifiedName(nullAtom, AtomicString(toAttr(i mportedNode)->name()), nullAtom), toAttr(importedNode)->value());
879 case DOCUMENT_FRAGMENT_NODE: { 879 case DOCUMENT_FRAGMENT_NODE: {
880 if (importedNode->isShadowRoot()) { 880 if (importedNode->isShadowRoot()) {
881 // ShadowRoot nodes should not be explicitly importable. 881 // ShadowRoot nodes should not be explicitly importable.
882 // Either they are imported along with their host node, or created i mplicitly. 882 // Either they are imported along with their host node, or created i mplicitly.
883 break; 883 break;
884 } 884 }
885 DocumentFragment* oldFragment = toDocumentFragment(importedNode); 885 DocumentFragment* oldFragment = toDocumentFragment(importedNode);
886 RefPtr<DocumentFragment> newFragment = createDocumentFragment(); 886 RefPtr<DocumentFragment> newFragment = createDocumentFragment();
887 if (deep) { 887 if (deep) {
888 for (Node* oldChild = oldFragment->firstChild(); oldChild; oldChild = oldChild->nextSibling()) { 888 for (Node* oldChild = oldFragment->firstChild(); oldChild; oldChild = oldChild->nextSibling()) {
(...skipping 3335 matching lines...) Expand 10 before | Expand all | Expand 10 after
4224 if (!parseQualifiedName(qualifiedName, prefix, localName, exceptionState)) 4224 if (!parseQualifiedName(qualifiedName, prefix, localName, exceptionState))
4225 return 0; 4225 return 0;
4226 4226
4227 QualifiedName qName(prefix, localName, namespaceURI); 4227 QualifiedName qName(prefix, localName, namespaceURI);
4228 4228
4229 if (!shouldIgnoreNamespaceChecks && !hasValidNamespaceForAttributes(qName)) { 4229 if (!shouldIgnoreNamespaceChecks && !hasValidNamespaceForAttributes(qName)) {
4230 exceptionState.throwDOMException(NamespaceError, "The namespace URI prov ided ('" + namespaceURI + "') is not valid for the qualified name provided ('" + qualifiedName + "')."); 4230 exceptionState.throwDOMException(NamespaceError, "The namespace URI prov ided ('" + namespaceURI + "') is not valid for the qualified name provided ('" + qualifiedName + "').");
4231 return 0; 4231 return 0;
4232 } 4232 }
4233 4233
4234 return Attr::create(*this, qName, emptyString()); 4234 return Attr::create(*this, qName, emptyAtom);
4235 } 4235 }
4236 4236
4237 const SVGDocumentExtensions* Document::svgExtensions() 4237 const SVGDocumentExtensions* Document::svgExtensions()
4238 { 4238 {
4239 return m_svgExtensions.get(); 4239 return m_svgExtensions.get();
4240 } 4240 }
4241 4241
4242 SVGDocumentExtensions* Document::accessSVGExtensions() 4242 SVGDocumentExtensions* Document::accessSVGExtensions()
4243 { 4243 {
4244 if (!m_svgExtensions) 4244 if (!m_svgExtensions)
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
5272 } 5272 }
5273 5273
5274 FastTextAutosizer* Document::fastTextAutosizer() 5274 FastTextAutosizer* Document::fastTextAutosizer()
5275 { 5275 {
5276 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d()) 5276 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d())
5277 m_fastTextAutosizer = FastTextAutosizer::create(this); 5277 m_fastTextAutosizer = FastTextAutosizer::create(this);
5278 return m_fastTextAutosizer.get(); 5278 return m_fastTextAutosizer.get();
5279 } 5279 }
5280 5280
5281 } // namespace WebCore 5281 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698