Make calls to AtomicString(const String&) explicit in dom/

Source/core/dom/DatasetDOMStringMap.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 89 matching lines @@
 static bool isValidPropertyName(const String& name)
 {
     unsigned length = name.length();
     for (unsigned i = 0; i < length; ++i) {
         if (name[i] == '-' && (i + 1 < length) && isASCIILower(name[i + 1]))
             return false;
     }
     return true;
 }
 
-static String convertPropertyNameToAttributeName(const String& name)
+// This returns an AtomicString because attribute names are always stored
+// as AtomicString types in Element (see setAttribute()).
+static AtomicString convertPropertyNameToAttributeName(const String& name)
 {
     StringBuilder builder;
     builder.append("data-");
 
     unsigned length = name.length();
     for (unsigned i = 0; i < length; ++i) {
         UChar character = name[i];
         if (isASCIIUpper(character)) {
             builder.append('-');
             builder.append(toASCIILower(character));
         } else
             builder.append(character);
     }
 
-    return builder.toString();
+    return builder.toAtomicString();
 }
 
 void DatasetDOMStringMap::ref()
 {
     m_element->ref();
 }
 
 void DatasetDOMStringMap::deref()
 {
     m_element->deref();
@@ skipping 42 matching lines @@
     return false;
 }
 
 void DatasetDOMStringMap::setItem(const String& name, const String& value, ExceptionState& exceptionState)
 {
     if (!isValidPropertyName(name)) {
         exceptionState.throwDOMException(SyntaxError, ExceptionMessages::failedToSet(name, "DOMStringMap", "'" + name + "' is not a valid property name."));
         return;
     }
 
-    m_element->setAttribute(convertPropertyNameToAttributeName(name), value, exceptionState);
+    m_element->setAttribute(convertPropertyNameToAttributeName(name), AtomicString(value), exceptionState);
 }
 
 bool DatasetDOMStringMap::deleteItem(const String& name)
 {
     if (isValidPropertyName(name)) {
-        String attributeName = convertPropertyNameToAttributeName(name);
+        AtomicString attributeName = convertPropertyNameToAttributeName(name);
         if (m_element->hasAttribute(attributeName)) {
             m_element->removeAttribute(attributeName);
             return true;
         }
     }
     return false;
 }
 
 } // namespace WebCore