Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Source/core/dom/ClassNodeList.h

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com) 3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 21 matching lines...) Expand all
32 32
33 #include "core/dom/Element.h" 33 #include "core/dom/Element.h"
34 #include "core/dom/LiveNodeList.h" 34 #include "core/dom/LiveNodeList.h"
35 #include "core/dom/Node.h" 35 #include "core/dom/Node.h"
36 #include "core/dom/SpaceSplitString.h" 36 #include "core/dom/SpaceSplitString.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class ClassNodeList FINAL : public LiveNodeList { 40 class ClassNodeList FINAL : public LiveNodeList {
41 public: 41 public:
42 static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, const Str ing& classNames) 42 // classNames argument is an AtomicString because it is common for Elements to share the same class names.
43 // It is also used to construct a SpaceSplitString (m_classNames) and its co nstructor requires an AtomicString.
44 static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, Collectio nType type, const AtomicString& classNames)
43 { 45 {
46 ASSERT_UNUSED(type, type == ClassNodeListType);
44 return adoptRef(new ClassNodeList(rootNode, classNames)); 47 return adoptRef(new ClassNodeList(rootNode, classNames));
45 } 48 }
46 49
47 virtual ~ClassNodeList(); 50 virtual ~ClassNodeList();
48 51
49 bool nodeMatchesInlined(Element*) const; 52 bool nodeMatchesInlined(Element*) const;
50 53
51 private: 54 private:
52 ClassNodeList(PassRefPtr<Node> rootNode, const String& classNames); 55 ClassNodeList(PassRefPtr<Node> rootNode, const AtomicString& classNames);
53 56
54 virtual bool nodeMatches(Element*) const OVERRIDE; 57 virtual bool nodeMatches(Element*) const OVERRIDE;
55 58
56 SpaceSplitString m_classNames; 59 SpaceSplitString m_classNames;
57 String m_originalClassNames; 60 AtomicString m_originalClassNames;
58 }; 61 };
59 62
60 inline bool ClassNodeList::nodeMatchesInlined(Element* testNode) const 63 inline bool ClassNodeList::nodeMatchesInlined(Element* testNode) const
61 { 64 {
62 if (!testNode->hasClass()) 65 if (!testNode->hasClass())
63 return false; 66 return false;
64 if (!m_classNames.size()) 67 if (!m_classNames.size())
65 return false; 68 return false;
66 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement. 69 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
67 // https://bugs.webkit.org/show_bug.cgi?id=94718 70 // https://bugs.webkit.org/show_bug.cgi?id=94718
68 if (!testNode->isStyledElement()) 71 if (!testNode->isStyledElement())
69 return false; 72 return false;
70 return testNode->classNames().containsAll(m_classNames); 73 return testNode->classNames().containsAll(m_classNames);
71 } 74 }
72 75
73 } // namespace WebCore 76 } // namespace WebCore
74 77
75 #endif // ClassNodeList_h 78 #endif // ClassNodeList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698