Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 845 matching lines...) Expand 10 before | Expand all | Expand 10 after
856 return 0; 856 return 0;
857 newElement->appendChild(newChild.release(), exceptionState); 857 newElement->appendChild(newChild.release(), exceptionState);
858 if (exceptionState.hadException()) 858 if (exceptionState.hadException())
859 return 0; 859 return 0;
860 } 860 }
861 } 861 }
862 862
863 return newElement.release(); 863 return newElement.release();
864 } 864 }
865 case ATTRIBUTE_NODE: 865 case ATTRIBUTE_NODE:
866 return Attr::create(*this, QualifiedName(nullAtom, toAttr(importedNode)- >name(), nullAtom), toAttr(importedNode)->value()); 866 return Attr::create(*this, QualifiedName(nullAtom, AtomicString(toAttr(i mportedNode)->name()), nullAtom), toAttr(importedNode)->value());
867 case DOCUMENT_FRAGMENT_NODE: { 867 case DOCUMENT_FRAGMENT_NODE: {
868 if (importedNode->isShadowRoot()) { 868 if (importedNode->isShadowRoot()) {
869 // ShadowRoot nodes should not be explicitly importable. 869 // ShadowRoot nodes should not be explicitly importable.
870 // Either they are imported along with their host node, or created i mplicitly. 870 // Either they are imported along with their host node, or created i mplicitly.
871 break; 871 break;
872 } 872 }
873 DocumentFragment* oldFragment = toDocumentFragment(importedNode); 873 DocumentFragment* oldFragment = toDocumentFragment(importedNode);
874 RefPtr<DocumentFragment> newFragment = createDocumentFragment(); 874 RefPtr<DocumentFragment> newFragment = createDocumentFragment();
875 if (deep) { 875 if (deep) {
876 for (Node* oldChild = oldFragment->firstChild(); oldChild; oldChild = oldChild->nextSibling()) { 876 for (Node* oldChild = oldFragment->firstChild(); oldChild; oldChild = oldChild->nextSibling()) {
(...skipping 3284 matching lines...) Expand 10 before | Expand all | Expand 10 after
4161 if (!parseQualifiedName(qualifiedName, prefix, localName, exceptionState)) 4161 if (!parseQualifiedName(qualifiedName, prefix, localName, exceptionState))
4162 return 0; 4162 return 0;
4163 4163
4164 QualifiedName qName(prefix, localName, namespaceURI); 4164 QualifiedName qName(prefix, localName, namespaceURI);
4165 4165
4166 if (!shouldIgnoreNamespaceChecks && !hasValidNamespaceForAttributes(qName)) { 4166 if (!shouldIgnoreNamespaceChecks && !hasValidNamespaceForAttributes(qName)) {
4167 exceptionState.throwUninformativeAndGenericDOMException(NamespaceError); 4167 exceptionState.throwUninformativeAndGenericDOMException(NamespaceError);
4168 return 0; 4168 return 0;
4169 } 4169 }
4170 4170
4171 return Attr::create(*this, qName, emptyString()); 4171 return Attr::create(*this, qName, emptyAtom);
4172 } 4172 }
4173 4173
4174 const SVGDocumentExtensions* Document::svgExtensions() 4174 const SVGDocumentExtensions* Document::svgExtensions()
4175 { 4175 {
4176 return m_svgExtensions.get(); 4176 return m_svgExtensions.get();
4177 } 4177 }
4178 4178
4179 SVGDocumentExtensions* Document::accessSVGExtensions() 4179 SVGDocumentExtensions* Document::accessSVGExtensions()
4180 { 4180 {
4181 if (!m_svgExtensions) 4181 if (!m_svgExtensions)
(...skipping 1032 matching lines...) Expand 10 before | Expand all | Expand 10 after
5214 } 5214 }
5215 5215
5216 FastTextAutosizer* Document::fastTextAutosizer() 5216 FastTextAutosizer* Document::fastTextAutosizer()
5217 { 5217 {
5218 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d()) 5218 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d())
5219 m_fastTextAutosizer = FastTextAutosizer::create(this); 5219 m_fastTextAutosizer = FastTextAutosizer::create(this);
5220 return m_fastTextAutosizer.get(); 5220 return m_fastTextAutosizer.get();
5221 } 5221 }
5222 5222
5223 } // namespace WebCore 5223 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698