Source/core/dom/DOMTokenList.h - Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/

Side by Side Diff: Source/core/dom/DOMTokenList.h

Issue 112843002: Make calls to AtomicString(const String&) explicit in dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/dom/ClassNodeList.h ('K') | « Source/core/dom/DOMSettableTokenList.cpp ('k') | Source/core/dom/DOMTokenList.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 void remove(const AtomicString&, ExceptionState&);	56 void remove(const AtomicString&, ExceptionState&);

57 bool toggle(const AtomicString&, ExceptionState&);	57 bool toggle(const AtomicString&, ExceptionState&);

58 bool toggle(const AtomicString&, bool force, ExceptionState&);	58 bool toggle(const AtomicString&, bool force, ExceptionState&);

59	59

60 AtomicString toString() const { return value(); }	60 AtomicString toString() const { return value(); }

61	61

62 virtual Element* element() { return 0; }	62 virtual Element* element() { return 0; }

63	63

64 protected:	64 protected:

65 virtual AtomicString value() const = 0;	65 virtual AtomicString value() const = 0;

66 virtual void setValue(const AtomicString&) = 0;	66 virtual void setValue(const AtomicString&) = 0;
	Inactive 2013/12/16 14:26:27 This takes an AtomicString. This takes an AtomicString.
67	67

68 virtual void addInternal(const AtomicString&);	68 virtual void addInternal(const AtomicString&);

69 virtual bool containsInternal(const AtomicString&) const = 0;	69 virtual bool containsInternal(const AtomicString&) const = 0;

70 virtual void removeInternal(const AtomicString&);	70 virtual void removeInternal(const AtomicString&);

71	71

72 static bool validateToken(const AtomicString&, ExceptionState&);	72 static bool validateToken(const String&, ExceptionState&);

73 static bool validateTokens(const Vector<String>&, ExceptionState&);	73 static bool validateTokens(const Vector<String>&, ExceptionState&);

74 static String addToken(const AtomicString&, const AtomicString&);	74 static AtomicString addToken(const AtomicString&, const AtomicString&);
	eseidel 2013/12/15 16:51:26 Why are these atomic? Why are these atomic? Inactive 2013/12/16 14:26:27 Because all the callers expect an AtomicString. Th Show quoted text On 2013/12/15 16:51:26, eseidel wrote: > Why are these atomic? Because all the callers expect an AtomicString. The returned value is always passed to DOMTokenList::setValue(const AtomicString&) defined above (see DOMTokenList.cpp). These methods use a StringBuilder internally so they can easily generate either a String or an AtomicString. Since all callers expect an AtomicString, it is more efficient to construct directly an AtomicString. eseidel 2013/12/30 17:19:27 You should add comments whenever you're changing t Show quoted text On 2013/12/16 14:26:27, Chris Dumez wrote: > On 2013/12/15 16:51:26, eseidel wrote: > > Why are these atomic? > > Because all the callers expect an AtomicString. The returned value is always > passed to DOMTokenList::setValue(const AtomicString&) defined above (see > DOMTokenList.cpp). > > These methods use a StringBuilder internally so they can easily generate either > a String or an AtomicString. Since all callers expect an AtomicString, it is > more efficient to construct directly an AtomicString. You should add comments whenever you're changing these to explain why various lasses use Atmic vs. Stirng and if they should IYO.
75 static String addTokens(const AtomicString&, const Vector<String>&);	75 static AtomicString addTokens(const AtomicString&, const Vector<String>&);

76 static String removeToken(const AtomicString&, const AtomicString&);	76 static AtomicString removeToken(const AtomicString&, const AtomicString&);

77 static String removeTokens(const AtomicString&, const Vector<String>&);	77 static AtomicString removeTokens(const AtomicString&, const Vector<String>&) ;

78 };	78 };

79	79

80 } // namespace WebCore	80 } // namespace WebCore

81	81

82 #endif // DOMTokenList_h	82 #endif // DOMTokenList_h

OLD	NEW