Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1128413002: Add Apps.AppListSearchQueryLength UMA histogram. (Closed)

Created:
5 years, 7 months ago by calamity
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tfarina, Matt Giuca, asvitkine+watch_chromium.org, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_launch_stats
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Apps.AppListSearchQueryLength UMA histogram. This CL adds a histogram to track the length of the app list search query at the time a result is opened. This will provide information about the efficiency of users of the app list search. BUG=485449 Committed: https://crrev.com/6508a61109dad09944bda378b3b6f3874bfa18a4 Cr-Commit-Position: refs/heads/master@{#329299}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/search_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
calamity
5 years, 7 months ago (2015-05-11 04:09:03 UTC) #3
Matt Giuca
lgtm, but aren't you adding a bunch of other histos at the same time? Wouldn't ...
5 years, 7 months ago (2015-05-11 04:27:37 UTC) #4
calamity
+asvitkine for histograms OWNERS.
5 years, 7 months ago (2015-05-11 06:52:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128413002/20001
5 years, 7 months ago (2015-05-11 06:54:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 08:07:58 UTC) #10
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-11 15:01:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128413002/20001
5 years, 7 months ago (2015-05-12 00:43:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-12 00:49:54 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:50:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6508a61109dad09944bda378b3b6f3874bfa18a4
Cr-Commit-Position: refs/heads/master@{#329299}

Powered by Google App Engine
This is Rietveld 408576698