Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 1128403004: Fix Frame::isMainFrame() to be compatible with provisional frames (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update stuff Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index 22ea043eb00c4b8850a27461a2aa8c0fda35c61a..0d2a4d42f7a225c200615ddf46e96d9e766bc6be 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -193,6 +193,8 @@ void WebRemoteFrameImpl::removeChild(WebFrame* frame)
WebDocument WebRemoteFrameImpl::document() const
{
+ // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of
+ // code tries to access the document of a remote frame at the moment.
return WebDocument();
}
« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698