media/base/android/media_player_android.cc - Issue 1128383003: Implementation of MediaCodecPlayer stage 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_android.cc

Issue 1128383003: Implementation of MediaCodecPlayer stage 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Min comments, added DCHECKs for current threads Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/media_player_android.cc

diff --git a/media/base/android/media_player_android.cc b/media/base/android/media_player_android.cc

index 60e1dfc0f823268042381b5e4514931290c3d2b8..2ca4c9f89abccdff6428bebaa5d60d83f6330c9b 100644

--- a/media/base/android/media_player_android.cc

+++ b/media/base/android/media_player_android.cc

@@ -24,8 +24,9 @@ MediaPlayerAndroid::MediaPlayerAndroid(

frame_url_(frame_url),

is_audible_(false),

weak_factory_(this) {

+ weak_ptr_for_ui_thread_ = weak_factory_.GetWeakPtr();

listener_.reset(new MediaPlayerListener(base::ThreadTaskRunnerHandle::Get(),

- weak_factory_.GetWeakPtr()));

+ weak_ptr_for_ui_thread_));

}

MediaPlayerAndroid::~MediaPlayerAndroid() {}

@@ -88,6 +89,7 @@ void MediaPlayerAndroid::DetachListener() {

void MediaPlayerAndroid::DestroyListenerOnUIThread() {

weak_factory_.InvalidateWeakPtrs();

+ weak_ptr_for_ui_thread_.reset();

listener_.reset();

}