Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: components/nacl/renderer/plugin/pnacl_translate_thread.h

Issue 1128373005: PNaCl: Hold subprocess_mu while doing StartSrpcServices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/plugin/pnacl_translate_thread.h
diff --git a/components/nacl/renderer/plugin/pnacl_translate_thread.h b/components/nacl/renderer/plugin/pnacl_translate_thread.h
index 183766947c1d52bee90722eb9559cd6d914aae3b..ca06d3df70644cb129153ab7e4822f6917902c71 100644
--- a/components/nacl/renderer/plugin/pnacl_translate_thread.h
+++ b/components/nacl/renderer/plugin/pnacl_translate_thread.h
@@ -113,9 +113,9 @@ class PnaclTranslateThread {
// subprocesses. The *_subprocess_active flags indicate which subprocesses
// are active to ensure the subprocesses don't get shutdown more than once.
// The subprocess_mu_ must be held when shutting down the subprocesses
- // or checking if it's already shut down (via the active flags).
+ // or otherwise accessing the service_runtime component of the subprocess.
// There are some accesses to the subprocesses without locks held
- // (invoking SRPC methods client).
+ // (invoking srpc_client methods -- in contrast to using the service_runtime).
NaClSubprocess* compiler_subprocess_;
NaClSubprocess* ld_subprocess_;
bool compiler_subprocess_active_;
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698