Switch Fizzy //components to use SchemeIsCryptographic() instead of SchemeIsSecure().

Switch Fizzy //components to use SchemeIsCryptographic() instead of SchemeIsSecure().

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214
Committed: https://crrev.com/fe50e76fa445ff8e6fc3d18bb4b8d3a6b1408730
Cr-Commit-Position: refs/heads/master@{#329269}

[lgarron, 2015-05-08 23:50:31]

Patchset #1 (id:1) has been deleted

[lgarron, 2015-05-08 23:52:29]

lgarron@chromium.org changed reviewers:
+ bauerb@chromium.org, dbeam@chromium.org

[lgarron, 2015-05-08 23:52:29]

Would you mind reviewing the following?

dbeam@: wallet_service_url_unittest.cc

bauerb@: host_content_settings_map.cc
(Updated based on https://codereview.chromium.org/1099453005/patch/160001/170013
I now know what a layered component is! :-)

[Dan Beam, 2015-05-08 23:57:05]

please fix the CL description as neither instance you're changing in
//components is actually using IsOriginSecure() (but SchemeIsCryptographic()
instead)

https://codereview.chromium.org/1128363006/diff/20001/components/autofill/con...
File components/autofill/content/browser/wallet/wallet_service_url_unittest.cc
(right):

https://codereview.chromium.org/1128363006/diff/20001/components/autofill/con...
components/autofill/content/browser/wallet/wallet_service_url_unittest.cc:9:
#include "content/public/common/origin_util.h"
^ don't think this is necessary

[lgarron, 2015-05-09 00:32:54]

Thanks for catching those!

(I thought I had fixed them, but I made a mistake.)

[Dan Beam, 2015-05-09 01:01:19]

lgtm

[Bernhard Bauer, 2015-05-11 07:48:15]

lgtm

[lgarron, 2015-05-11 19:44:24]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:46:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128363006/40001

[commit-bot: I haz the power, 2015-05-11 19:53:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:53:07]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2015-05-11 22:39:04]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-05-11 22:41:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128363006/40001

[commit-bot: I haz the power, 2015-05-11 23:14:40]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-11 23:15:35]

Patchset 2 (id:??) landed as
https://crrev.com/fe50e76fa445ff8e6fc3d18bb4b8d3a6b1408730
Cr-Commit-Position: refs/heads/master@{#329269}