Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 1128353005: Disallow multiple selection in desktop media picker. (Closed)

Created:
5 years, 7 months ago by Sergey Ulanov
Modified:
5 years, 7 months ago
Reviewers:
Nico, dcaiafa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow multiple selection in desktop media picker. Previously the picker was allowing multiple source selection. Now DesktopMediaPickerController sets allowsMultipleSelection to NO in IKImageBrowserView to disable this feature. BUG=466997 Committed: https://crrev.com/cb535608fda92744d95367cfa2ac9a11c3e49641 Cr-Commit-Position: refs/heads/master@{#330453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Sergey Ulanov
5 years, 7 months ago (2015-05-18 17:43:51 UTC) #2
Nico
Does this affect picking multiple media files in other places? (Say, image upload or whatnot)
5 years, 7 months ago (2015-05-18 17:55:40 UTC) #3
Sergey Ulanov
On 2015/05/18 17:55:40, Nico wrote: > Does this affect picking multiple media files in other ...
5 years, 7 months ago (2015-05-18 18:22:53 UTC) #4
Nico
I mean "is desktop_media_picker_controller.mm used in any places where multiple selections are desired?" If not, ...
5 years, 7 months ago (2015-05-18 20:11:41 UTC) #5
Sergey Ulanov
On 2015/05/18 20:11:41, Nico wrote: > I mean "is desktop_media_picker_controller.mm used in any places where ...
5 years, 7 months ago (2015-05-18 20:14:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128353005/1
5 years, 7 months ago (2015-05-18 23:18:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 00:03:35 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:04:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb535608fda92744d95367cfa2ac9a11c3e49641
Cr-Commit-Position: refs/heads/master@{#330453}

Powered by Google App Engine
This is Rietveld 408576698