Issue 1128353004: Revert of SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128353004: Revert of SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig (Closed)

Created:
5 years, 7 months ago by hal.canary

Modified:
5 years, 7 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig (patchset #7 id:570001 of https://codereview.chromium.org/1134683006/) Reason for revert: break cros build Original issue's description: > SkPDF: Add Sfntly to DEPS, gyp > > Note: this can be disabled via: > GYP_DEFINES='skia_pdf_use_sfntly=0 > > Warning: dm is 34% slower and uses 9% more memory. This is > okay. > > Motivation: We want to test this code path in DM, since it is > always used by Chromium and Android. > > BUG=skia:3563 > > Committed: https://skia.googlesource.com/skia/+/6a53b04e26749ea61f690ece408f2a1c0a5ad5bb TBR=reed@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3563 Committed: https://skia.googlesource.com/skia/+/9bedfc23fe01bed5ea939f860d64e57e6333abe7

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -183 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	gyp/icu.gyp	View	1 chunk	+0 lines, -117 lines	0 comments	Download
M	gyp/pdf.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	gyp/sfntly.gyp	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

hal.canary

Created Revert of SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig

5 years, 7 months ago (2015-05-18 17:26:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128353004/1

5 years, 7 months ago (2015-05-18 17:27:06 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 17:27:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9bedfc23fe01bed5ea939f860d64e57e6333abe7