Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1128333002: Moterm part 2: Add MotermDriver, a terminal "driver". (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
Elliot Glaysher, erg
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@moterm_model
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Moterm part 2: Add MotermDriver, a terminal "driver". (This is the thing that connects a "file" with something that looks like a serial device. In fine Unix tradition, it does other things too, e.g., support line editing.) R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c0b03df6cf0d4f38a3574e58c25485fa6cd57735

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Patch Set 3 : rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+842 lines, -0 lines) Patch
M apps/moterm/BUILD.gn View 2 chunks +16 lines, -0 lines 0 comments Download
A apps/moterm/moterm_driver.h View 1 chunk +169 lines, -0 lines 0 comments Download
A apps/moterm/moterm_driver.cc View 1 chunk +374 lines, -0 lines 0 comments Download
A apps/moterm/moterm_driver_unittest.cc View 1 chunk +283 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1130563002/.)
5 years, 7 months ago (2015-05-06 21:03:18 UTC) #1
viettrungluu
-> erg (still dependent on https://codereview.chromium.org/1130563002/)
5 years, 7 months ago (2015-05-11 19:25:25 UTC) #3
Elliot Glaysher
lgtm https://codereview.chromium.org/1128333002/diff/1/apps/moterm/moterm_driver.cc File apps/moterm/moterm_driver.cc (right): https://codereview.chromium.org/1128333002/diff/1/apps/moterm/moterm_driver.cc#newcode61 apps/moterm/moterm_driver.cc:61: icrnl_(true), I was about to complain about the ...
5 years, 7 months ago (2015-05-11 20:22:49 UTC) #5
viettrungluu
Thanks. On 2015/05/11 20:22:49, Elliot Glaysher wrote: > lgtm > > https://codereview.chromium.org/1128333002/diff/1/apps/moterm/moterm_driver.cc > File apps/moterm/moterm_driver.cc ...
5 years, 7 months ago (2015-05-11 20:34:22 UTC) #6
viettrungluu
5 years, 7 months ago (2015-05-11 20:51:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c0b03df6cf0d4f38a3574e58c25485fa6cd57735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698