Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1128323003: Remove explicit double alignment from allocation helper functions. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove explicit double alignment from allocation helper functions. BUG= Committed: https://crrev.com/250f591c94c234a27b8e94330cfdb3240feda677 Cr-Commit-Position: refs/heads/master@{#28320}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M src/heap/heap.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 4 chunks +12 lines, -26 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-08 11:44:39 UTC) #2
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-08 11:45:42 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1128323003/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1128323003/diff/1/src/heap/heap.h#newcode1824 src/heap/heap.h:1824: bool double_align = false); Please don't use bool. Add ...
5 years, 7 months ago (2015-05-08 11:47:43 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1128323003/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1128323003/diff/1/src/heap/heap.h#newcode1824 src/heap/heap.h:1824: bool double_align = false); On 2015/05/08 11:47:42, Benedikt Meurer ...
5 years, 7 months ago (2015-05-08 11:59:25 UTC) #6
Benedikt Meurer
LGTM once comment addressed https://codereview.chromium.org/1128323003/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1128323003/diff/20001/src/heap/heap.h#newcode1818 src/heap/heap.h:1818: enum Alignment { kWordAligned, kDoubleWordAligned ...
5 years, 7 months ago (2015-05-08 12:01:31 UTC) #7
Hannes Payer (out of office)
https://codereview.chromium.org/1128323003/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1128323003/diff/20001/src/heap/heap.h#newcode1818 src/heap/heap.h:1818: enum Alignment { kWordAligned, kDoubleWordAligned }; On 2015/05/08 12:01:31, ...
5 years, 7 months ago (2015-05-08 12:04:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128323003/40001
5 years, 7 months ago (2015-05-08 13:24:35 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-08 14:11:53 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 14:12:12 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/250f591c94c234a27b8e94330cfdb3240feda677
Cr-Commit-Position: refs/heads/master@{#28320}

Powered by Google App Engine
This is Rietveld 408576698