Convert search_engines_page (and search_engine-adder) to be compatible with Polymer 0.8.

chrome/browser/resources/settings/search_engines_page/search_engines_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'cr-settings-search-engines-page' is the settings page
  * containing search engines settings.
  *
  * Example:
  *
  *    <core-animated-pages>
  *      <cr-settings-search-engines-page prefs="{{prefs}}">
  *      </cr-settings-search-engines-page>
  *      ... other pages ...
  *    </core-animated-pages>
  *
  * @group Chrome Settings Elements
  * @element cr-settings-search-engines-page
  */
-Polymer('cr-settings-search-engines-page', {
-  publish: {
+Polymer({
+  is: 'cr-settings-search-engines-page',
+
+  properties: {
     /**
      * Preferences state.
-     *
-     * @attribute prefs
-     * @type {CrSettingsPrefsElement}
-     * @default null
+     * @type {?CrSettingsPrefsElement}
      */
-    prefs: null,
+    prefs: {
+      type: Object,
+      notify: true
+    },
 
     /**
      * Route for the page.
-     *
-     * @attribute route
-     * @type {string}
-     * @default ''
      */
-    route: '',
+    route: {
+      type: String,
+      value: ''
+    },
 
     /**
      * Whether the page is a subpage.
-     *
-     * @attribute subpage
-     * @type {boolean}
-     * @default true
      */
-    subpage: true,
+    subpage: {
+      type: Boolean,
+      value: true,
+      readOnly: true
+    },
 
     /**
      * ID of the page.
-     *
-     * @attribute PAGE_ID
-     * @const {string}
-     * @default 'search'
      */
-    PAGE_ID: 'search_engines',
+    PAGE_ID: {
+      type: String,
+      value: 'search_engines',
+      readOnly: true
+    },
 
     /**
      * Title for the page header and navigation menu.
-     *
-     * @attribute pageTitle
-     * @type {string}
      */
-    pageTitle: loadTimeData.getString('searchEnginesPageTitle'),
+    pageTitle: {
+      type: String,
+      value: loadTimeData.getString('searchEnginesPageTitle'),
+      readOnly: true
+    },
 
     /**
      * Name of the 'core-icon' to be shown in the settings-page-header.
-     *
-     * @attribute icon
-     * @type {string}
-     * @default 'search'
      */
-    icon: 'search',
+    icon: {
+      type: String,
+      value: 'search',
+      readOnly: true
+    },
 
     /**
      * List of default search engines available.
-     *
-     * @attribute defaultSearchEngines
-     * @type {Array<!SearchEngine>}
-     * @default null
+     * @type {!Array<!SearchEngine>}
      */
-    defaultSearchEngines: null,
+    defaultSearchEngines: {
+      type: Array,
+      value: function() { return []; }
+    },
 
     /**
      * List of other search engines available.
-     *
-     * @attribute otherSearchEngines
-     * @type {Array<!SearchEngine>}
-     * @default null
+     * @type {!Array<!SearchEngine>}
      */
-    otherSearchEngines: null,
+    otherSearchEngines: {
+      type: Array,
+      value: function() { return []; }
+    },
 
     /**
      * GUID of the currently selected default search engine.
-     *
-     * @attribute defaultEngineGuid
-     * @type {string}
-     * @default ''
      */
-    defaultEngineGuid: '',
+    defaultEngineGuid: {
+      type: String,
+      value: '',
+      observer: 'deafultEngineGuidChanged'
+    },
   },
 
   /** @override */
-  created: function() {
-    this.searchEngines = [];
-  },
-
-  /** @override */
   domReady: function() {

[Jeremy Klein, 2015/05/13 00:19:54]

I'm still in favor of killing all this dead code... Also domReady doesn't exist
in 0.8

[Kyle Horimoto, 2015/05/13 02:38:28]

Meh, I'll keep this in just because I know Oren will need to use it eventually.
What's the equivalent of domReady() in 0.8? I couldn't find it in the migration
guide.

[Jeremy Klein, 2015/05/13 02:40:15]

He won't need this. It's literally exactly the same code line-for-line as the
old search_page so I doubt he left it intentionally. I'd rather have him add
back in the right implementation.

[Kyle Horimoto, 2015/05/13 02:58:46]

Done.

     chrome.searchEnginesPrivate.onSearchEnginesChanged.addListener(
         this.updateSearchEngines_.bind(this));
     chrome.searchEnginesPrivate.getSearchEngines(
         this.updateSearchEngines_.bind(this));
   },
 
   /**
    * Persists the new default search engine back to Chrome. Called when the
    * user selects a new default in the search engines dropdown.
    */
   defaultEngineGuidChanged: function() {
     chrome.searchEnginesPrivate.setSelectedSearchEngine(this.defaultEngineGuid);
   },
 
-
   /**
    * Updates the lists of search engines based on the given |engines|.
    * @param {!Array<!SearchEngine>} engines All the search engines.
    * @private
    */
   updateSearchEngines_: function(engines) {
     var defaultEngines = [];
     var otherEngines = [];
 
     engines.forEach(function(engine) {
       if (engine.type ==
           chrome.searchEnginesPrivate.SearchEngineType.DEFAULT) {
         defaultEngines.push(engine);
         if (engine.isSelected) {
           this.defaultEngineGuid = engine.guid;
         }
       } else if (engine.type ==
                  chrome.searchEnginesPrivate.SearchEngineType.OTHER) {
         otherEngines.push(engine);
       }
     }, this);
 
     this.defaultSearchEngines = defaultEngines;
     this.otherSearchEngines = otherEngines;
   }
 });