Convert search_engines_page (and search_engine-adder) to be compatible with Polymer 0.8.

Convert search_engines_page (and search_engine-adder) to be compatible with Polymer 0.8.

Committed: https://crrev.com/831b8719cb146bbaf67d172c753a7cc34881b272
Cr-Commit-Position: refs/heads/master@{#329583}

[Kyle Horimoto, 2015-05-12 20:46:17]

khorimoto@chromium.org changed reviewers:
+ jlklein@chromium.org

[Jeremy Klein, 2015-05-12 21:02:37]

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:2:
<link rel="import"
href="chrome://resources/cr_elements/cr_button/cr_button.html">
The cr_elements need v0_8 too.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:14:
<div class="container layout horizontal">
You need to import iron-flex-layout/classes/iron-flex-layout.html to use these.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:30:
<cr-input id="queryURLField" autoValidate="false" required>
I think this might need to be auto-validate. Same above.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.html
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.html:9:
<paper-material class="layout vertical">
Don't need the class because I'm updating settings_page.css to do this.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:28:
prefs: null,
Object, notify:true.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:41:
* @type {boolean}
nit: Remove unnecessary @type on primitives.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:43:
subpage: {
Make this, PAGE_ID, and icon readOnly: true.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:116:
defaultEngineGuidChanged: function() {
Well... Seems like half this file isn't used. Hooray copy-pasta!

[Kyle Horimoto, 2015-05-12 21:41:53]

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:2:
<link rel="import"
href="chrome://resources/cr_elements/cr_button/cr_button.html">
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> The cr_elements need v0_8 too.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:14:
<div class="container layout horizontal">
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> You need to import iron-flex-layout/classes/iron-flex-layout.html to use
these. 

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:30:
<cr-input id="queryURLField" autoValidate="false" required>
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> I think this might need to be auto-validate. Same above.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.html
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.html:9:
<paper-material class="layout vertical">
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> Don't need the class because I'm updating settings_page.css to do this.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:28:
prefs: null,
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> Object, notify:true.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:41:
* @type {boolean}
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> nit: Remove unnecessary @type on primitives.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:43:
subpage: {
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> Make this, PAGE_ID, and icon readOnly: true.

Done.

https://codereview.chromium.org/1128313004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:116:
defaultEngineGuidChanged: function() {
On 2015/05/12 21:02:36, Jeremy Klein wrote:
> Well... Seems like half this file isn't used. Hooray copy-pasta!

Lame. Added a TODO in the HTML file for Oren to fix this again. I saw him
working on it a few weeks back so I know something was working, but I guess it
got lost.

[Jeremy Klein, 2015-05-13 00:19:55]

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.css
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.css:1:
.input-label {
Need copyright.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:19:
<cr-input id="domainField" autoValidate="true" required>
haha I meant to just change the attribute name to "auto-valid". My bad.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.css
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.css:1:
.manage-search-engines {
This file is also all copy pasta... I think we can kill this too.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:106:
domReady: function() {
I'm still in favor of killing all this dead code... Also domReady doesn't exist
in 0.8

[Kyle Horimoto, 2015-05-13 02:38:28]

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.css
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.css:1:
.input-label {
On 2015/05/13 00:19:54, Jeremy Klein wrote:
> Need copyright.

Done.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_adder.html:19:
<cr-input id="domainField" autoValidate="true" required>
On 2015/05/13 00:19:54, Jeremy Klein wrote:
> haha I meant to just change the attribute name to "auto-valid". My bad.

Done.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.css
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.css:1:
.manage-search-engines {
On 2015/05/13 00:19:54, Jeremy Klein wrote:
> This file is also all copy pasta... I think we can kill this too.

Done.

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:106:
domReady: function() {
On 2015/05/13 00:19:54, Jeremy Klein wrote:
> I'm still in favor of killing all this dead code... Also domReady doesn't
exist
> in 0.8

Meh, I'll keep this in just because I know Oren will need to use it eventually.
What's the equivalent of domReady() in 0.8? I couldn't find it in the migration
guide.

[Jeremy Klein, 2015-05-13 02:40:16]

lgtm

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:106:
domReady: function() {
On 2015/05/13 02:38:28, Kyle Horimoto wrote:
> On 2015/05/13 00:19:54, Jeremy Klein wrote:
> > I'm still in favor of killing all this dead code... Also domReady doesn't
> exist
> > in 0.8
> 
> Meh, I'll keep this in just because I know Oren will need to use it
eventually.
> What's the equivalent of domReady() in 0.8? I couldn't find it in the
migration
> guide.

He won't need this. It's literally exactly the same code line-for-line as the
old search_page so I doubt he left it intentionally. I'd rather have him add
back in the right implementation.

[Kyle Horimoto, 2015-05-13 02:58:46]

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/1128313004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:106:
domReady: function() {
On 2015/05/13 02:40:15, Jeremy Klein wrote:
> On 2015/05/13 02:38:28, Kyle Horimoto wrote:
> > On 2015/05/13 00:19:54, Jeremy Klein wrote:
> > > I'm still in favor of killing all this dead code... Also domReady doesn't
> > exist
> > > in 0.8
> > 
> > Meh, I'll keep this in just because I know Oren will need to use it
> eventually.
> > What's the equivalent of domReady() in 0.8? I couldn't find it in the
> migration
> > guide.
> 
> He won't need this. It's literally exactly the same code line-for-line as the
> old search_page so I doubt he left it intentionally. I'd rather have him add
> back in the right implementation.

Done.

[Kyle Horimoto, 2015-05-13 03:00:42]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2015-05-13 03:00:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jlklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1128313004/#ps60001
(title: "jlklein comments.")

[commit-bot: I haz the power, 2015-05-13 03:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128313004/60001

[commit-bot: I haz the power, 2015-05-13 04:18:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-13 04:18:47]

Patchset 4 (id:??) landed as
https://crrev.com/831b8719cb146bbaf67d172c753a7cc34881b272
Cr-Commit-Position: refs/heads/master@{#329583}