Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1128313003: Use a generic runner for all Closure tests. (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
agable
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Use a generic runner for all Closure tests. CL that adds run_test.py: https://codereview.chromium.org/1137933003/ R=agable@chromium.org BUG=393873 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M scripts/slave/recipes/closure_compilation.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/main.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dan Beam
5 years, 7 months ago (2015-05-12 04:33:25 UTC) #1
agable
lgtm
5 years, 7 months ago (2015-05-13 01:37:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128313003/1
5 years, 7 months ago (2015-05-13 18:00:15 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:09:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295250

Powered by Google App Engine
This is Rietveld 408576698