Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: Source/bindings/core/v8/WorkerScriptDebugServer.h

Issue 1128273005: Devtools: Move runMessageLoopOnPause and other methods on ScriptDebugServer::Client (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove empty line Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/WorkerScriptDebugServer.h
diff --git a/Source/bindings/core/v8/WorkerScriptDebugServer.h b/Source/bindings/core/v8/WorkerScriptDebugServer.h
index 4e0f9b1a24bd54d42c3c8661ca996fb1444aee89..1a31dcea551b58b16dac4cba4470e775fbbd58d5 100644
--- a/Source/bindings/core/v8/WorkerScriptDebugServer.h
+++ b/Source/bindings/core/v8/WorkerScriptDebugServer.h
@@ -31,14 +31,14 @@
#ifndef WorkerScriptDebugServer_h
#define WorkerScriptDebugServer_h
-#include "bindings/core/v8/ScriptDebugServer.h"
+#include "core/inspector/PerIsolateDebuggerClient.h"
#include <v8.h>
namespace blink {
class WorkerGlobalScope;
-class WorkerScriptDebugServer final : public ScriptDebugServer {
+class WorkerScriptDebugServer final : public PerIsolateDebuggerClient {
WTF_MAKE_NONCOPYABLE(WorkerScriptDebugServer);
public:
static PassOwnPtrWillBeRawPtr<WorkerScriptDebugServer> create(WorkerGlobalScope* workerGlobalScope)
@@ -47,19 +47,17 @@ public:
}
~WorkerScriptDebugServer() override { }
- DECLARE_VIRTUAL_TRACE();
static void setContextDebugData(v8::Local<v8::Context>);
void addListener(ScriptDebugListener*);
void removeListener(ScriptDebugListener*);
+ ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>);
+ void runMessageLoopOnPause(v8::Local<v8::Context>);
+ void quitMessageLoopOnPause();
private:
explicit WorkerScriptDebugServer(WorkerGlobalScope*);
- ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) override;
- void runMessageLoopOnPause(v8::Local<v8::Context>) override;
yurys 2015/05/08 10:59:15 These methods should also stay private for clarity
sergeyv 2015/05/08 13:59:14 Done.
- void quitMessageLoopOnPause() override;
-
ScriptDebugListener* m_listener;
RawPtrWillBeMember<WorkerGlobalScope> m_workerGlobalScope;
};

Powered by Google App Engine
This is Rietveld 408576698