Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1128273004: Revert of Revert of Fixit: Factor out common base::Time* math operator overloads. (Closed)

Created:
5 years, 7 months ago by miu
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Kunihiko Sakamoto, smut
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #1 id:1 of https://codereview.chromium.org/1130953002/) Reason for revert: iOS_Device builder was not rebuilding certain modules dependent on changes in base::Time. http://crbug.com/485435 Original issue's description: > Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/) > > Reason for revert: > Broke iOS build. > > http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio > > Original issue's description: > > Fixit: Factor out common base::Time* math operator overloads. > > > > This is part 1 of a 2-part change to fork base::TimeTicks into three > > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The > > forking of TimeTicks will ensure values from different clocks are not > > erroneously being mixed together when doing time math. > > > > In this change, the identical comparison and math operator overloads > > found in base::Time and base::TimeTicks are being factored-out into a > > templated base class. In a following change, this base class will also > > be used to de-dupe this common functionality in the two new time > > classes. > > > > BUG=467417 > > > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d > > Cr-Commit-Position: refs/heads/master@{#328696} > > TBR=thestig@chromium.org,miu@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=467417 > > Committed: https://crrev.com/a365825583412c355a449274bec70e41e992ffd7 > Cr-Commit-Position: refs/heads/master@{#328706} TBR=thestig@chromium.org,ksakamoto@chromium.org NOPRESUBMIT=true BUG=467417, 485435 Committed: https://crrev.com/59fca1cd30487a013b942acf9d660dfcc639e25a Cr-Commit-Position: refs/heads/master@{#328843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -221 lines) Patch
M base/time/time.h View 17 chunks +160 lines, -208 lines 0 comments Download
M base/time/time.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M base/time/time_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
miu
Created Revert of Revert of Fixit: Factor out common base::Time* math operator overloads.
5 years, 7 months ago (2015-05-07 04:56:29 UTC) #1
miu
Sorry for the spam. I created a revert to re-run the iOS trybots. I suspect ...
5 years, 7 months ago (2015-05-07 05:30:39 UTC) #2
miu
Okay, I'm going to land this revert-of-revert, but will have it go through the CQ ...
5 years, 7 months ago (2015-05-07 18:37:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128273004/1
5 years, 7 months ago (2015-05-07 18:40:36 UTC) #6
miu
...and once again, I see the iOS bots are green for this change (in the ...
5 years, 7 months ago (2015-05-07 18:56:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 21:42:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/59fca1cd30487a013b942acf9d660dfcc639e25a Cr-Commit-Position: refs/heads/master@{#328843}
5 years, 7 months ago (2015-05-07 21:44:50 UTC) #9
Garrett Casto
5 years, 7 months ago (2015-05-07 22:30:33 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1125283003/ by gcasto@chromium.org.

The reason for reverting is: Still breaks iOS bots. Tracking at
crbug.com/485435..

Powered by Google App Engine
This is Rietveld 408576698