Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1128253005: Enable extension browser tests on debug windows. (Closed)

Created:
5 years, 7 months ago by hubbe
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable extension browser tests on debug windows. BUG=177163 Committed: https://crrev.com/121cbb5f7fce9719ab6152cb2e059575df8139d6 Cr-Commit-Position: refs/heads/master@{#329495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128253005/1
5 years, 7 months ago (2015-05-12 17:14:10 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 17:57:26 UTC) #4
hubbe
5 years, 7 months ago (2015-05-12 18:00:43 UTC) #6
asargent_no_longer_on_chrome
lgtm
5 years, 7 months ago (2015-05-12 19:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128253005/1
5 years, 7 months ago (2015-05-12 20:42:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 21:30:33 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/121cbb5f7fce9719ab6152cb2e059575df8139d6 Cr-Commit-Position: refs/heads/master@{#329495}
5 years, 7 months ago (2015-05-12 21:31:30 UTC) #11
sergeyv
5 years, 7 months ago (2015-05-13 12:55:59 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1134333003/ by sergeyv@chromium.org.

The reason for reverting is:  GcdPrivateAPITest.WifiPasswords fails after this
patch.

Failure example: 
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%....

Powered by Google App Engine
This is Rietveld 408576698