DescriptionRevert of Let layoutAndPaintAsync() schedule commit asynchronously (patchset #2 id:20001 of https://codereview.chromium.org/1126313004/)
Reason for revert:
Seems to cause the following layout tests' crash:
virtual/slimmingpaint/svg/custom/hit-test-with-br.xhtml
virtual/slimmingpaint/svg/custom/hit-test-unclosed-subpaths.svg
virtual/slimmingpaint/svg/custom/js-update-container2.svg
virtual/slimmingpaint/svg/custom/scroll-hit-test.xhtml
virtual/slimmingpaint/svg/custom/repaint-shadow.svg
virtual/slimmingpaint/svg/custom/use-event-handler-on-use-element.svg
virtual/slimmingpaint/svg/custom/prevent-default.svg
virtual/slimmingpaint/svg/custom/use-event-handler-on-referenced-element.svg
virtual/slimmingpaint/svg/as-object/embedded-svg-size-changes.html
virtual/slimmingpaint/svg/as-object/nested-embedded-svg-size-changes.html
virtual/slimmingpaint/svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
virtual/slimmingpaint/svg/zoom/text/absolute-sized-document-scrollbars.svg
virtual/slimmingpaint/svg/zoom/text/zoom-foreignObject.svg
virtual/slimmingpaint/svg/zoom/text/zoom-coords-viewattr-01-b.svg
virtual/slimmingpaint/svg/zoom/text/absolute-sized-document-no-scrollbars.svg
virtual/slimmingpaint/svg/zoom/text/relative-sized-document-scrollbars.svg
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/custom/use-event-handler-on-use-element.svg
svg/custom/hit-test-with-br.xhtml
svg/custom/scroll-hit-test.xhtml
svg/custom/js-update-container2.svg
svg/custom/repaint-shadow.svg
svg/custom/hit-test-unclosed-subpaths.svg
svg/custom/prevent-default.svg
svg/custom/use-event-handler-on-referenced-element.svg
---
3 libcontent.so!content::RenderWidgetCompositor::compositeAndReadbackAsync(blink::WebCompositeAndReadbackAsyncCallback*) + 0x10d
rbp = 0x00007fffea4d47b0 rsp = 0x00007fffea4d45c0
rip = 0x00007f04f3018e7d
Found by: call frame info
4 libblink_web.so!blink::WebView::zoomFactorToZoomLevel(double) + 0x9699
rbp = 0x00007fffea4d47e0 rsp = 0x00007fffea4d47c0
rip = 0x00007f04eda2da99
Found by: call frame info
---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/824
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/825
Original issue's description:
> Let layoutAndPaintAsync() schedule commit asynchronously
>
> Previously in single-threaded mode we let layoutAndPaintAsync()
> call commit synchronously and callback asynchronously. The synchronous
> commit causes reentrant of notifyDone() or requestAnimationFrame() for
> some tests having event handlers that are triggered by layout.
>
> Avoid reentrant by making commit always asynchronous.
>
> BUG=485428, 484706
> TEST=Webkit layout tests when they use layoutAndPaintAsyncThen().
>
> Committed: https://crrev.com/bccaf6b4f911baf2b84f56582b52d6ae6c818afb
> Cr-Commit-Position: refs/heads/master@{#328815}
TBR=sievers@chromium.org,wangxianzhu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485428, 484706
Patch Set 1 #
Created: 5 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (1 generated)
|