Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1128253004: Revert of Let layoutAndPaintAsync() schedule commit asynchronously (Closed)

Created:
5 years, 7 months ago by tasak
Modified:
5 years, 7 months ago
Reviewers:
Xianzhu, no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, piman+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Let layoutAndPaintAsync() schedule commit asynchronously (patchset #2 id:20001 of https://codereview.chromium.org/1126313004/) Reason for revert: Seems to cause the following layout tests' crash: virtual/slimmingpaint/svg/custom/hit-test-with-br.xhtml virtual/slimmingpaint/svg/custom/hit-test-unclosed-subpaths.svg virtual/slimmingpaint/svg/custom/js-update-container2.svg virtual/slimmingpaint/svg/custom/scroll-hit-test.xhtml virtual/slimmingpaint/svg/custom/repaint-shadow.svg virtual/slimmingpaint/svg/custom/use-event-handler-on-use-element.svg virtual/slimmingpaint/svg/custom/prevent-default.svg virtual/slimmingpaint/svg/custom/use-event-handler-on-referenced-element.svg virtual/slimmingpaint/svg/as-object/embedded-svg-size-changes.html virtual/slimmingpaint/svg/as-object/nested-embedded-svg-size-changes.html virtual/slimmingpaint/svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml virtual/slimmingpaint/svg/zoom/text/absolute-sized-document-scrollbars.svg virtual/slimmingpaint/svg/zoom/text/zoom-foreignObject.svg virtual/slimmingpaint/svg/zoom/text/zoom-coords-viewattr-01-b.svg virtual/slimmingpaint/svg/zoom/text/absolute-sized-document-no-scrollbars.svg virtual/slimmingpaint/svg/zoom/text/relative-sized-document-scrollbars.svg svg/as-object/embedded-svg-size-changes.html svg/as-object/nested-embedded-svg-size-changes.html svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml svg/zoom/text/absolute-sized-document-scrollbars.svg svg/zoom/text/zoom-foreignObject.svg svg/zoom/text/zoom-coords-viewattr-01-b.svg svg/zoom/text/absolute-sized-document-no-scrollbars.svg svg/zoom/text/relative-sized-document-scrollbars.svg svg/custom/use-event-handler-on-use-element.svg svg/custom/hit-test-with-br.xhtml svg/custom/scroll-hit-test.xhtml svg/custom/js-update-container2.svg svg/custom/repaint-shadow.svg svg/custom/hit-test-unclosed-subpaths.svg svg/custom/prevent-default.svg svg/custom/use-event-handler-on-referenced-element.svg --- 3 libcontent.so!content::RenderWidgetCompositor::compositeAndReadbackAsync(blink::WebCompositeAndReadbackAsyncCallback*) + 0x10d rbp = 0x00007fffea4d47b0 rsp = 0x00007fffea4d45c0 rip = 0x00007f04f3018e7d Found by: call frame info 4 libblink_web.so!blink::WebView::zoomFactorToZoomLevel(double) + 0x9699 rbp = 0x00007fffea4d47e0 rsp = 0x00007fffea4d47c0 rip = 0x00007f04eda2da99 Found by: call frame info --- https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/824 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/825 Original issue's description: > Let layoutAndPaintAsync() schedule commit asynchronously > > Previously in single-threaded mode we let layoutAndPaintAsync() > call commit synchronously and callback asynchronously. The synchronous > commit causes reentrant of notifyDone() or requestAnimationFrame() for > some tests having event handlers that are triggered by layout. > > Avoid reentrant by making commit always asynchronous. > > BUG=485428, 484706 > TEST=Webkit layout tests when they use layoutAndPaintAsyncThen(). > > Committed: https://crrev.com/bccaf6b4f911baf2b84f56582b52d6ae6c818afb > Cr-Commit-Position: refs/heads/master@{#328815} TBR=sievers@chromium.org,wangxianzhu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485428, 484706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tasak
Created Revert of Let layoutAndPaintAsync() schedule commit asynchronously
5 years, 7 months ago (2015-05-08 01:46:17 UTC) #1
Xianzhu
On 2015/05/08 01:46:17, tasak wrote: > Created Revert of Let layoutAndPaintAsync() schedule commit asynchronously Don't ...
5 years, 7 months ago (2015-05-08 01:47:34 UTC) #3
Xianzhu
On 2015/05/08 01:47:34, Xianzhu wrote: > On 2015/05/08 01:46:17, tasak wrote: > > Created Revert ...
5 years, 7 months ago (2015-05-08 01:51:13 UTC) #4
tasak
On 2015/05/08 01:51:13, Xianzhu wrote: > On 2015/05/08 01:47:34, Xianzhu wrote: > > On 2015/05/08 ...
5 years, 7 months ago (2015-05-08 03:20:25 UTC) #5
Xianzhu
5 years, 7 months ago (2015-05-08 03:25:05 UTC) #6
Message was sent while issue was closed.
On 2015/05/08 03:20:25, tasak wrote:
> On 2015/05/08 01:51:13, Xianzhu wrote:
> > On 2015/05/08 01:47:34, Xianzhu wrote:
> > > On 2015/05/08 01:46:17, tasak wrote:
> > > > Created Revert of Let layoutAndPaintAsync() schedule commit
asynchronously
> > > 
> > > Don't submit this. The tests has been marked failure in TestExpectations,
> and
> > > I'm fixing them.
> > 
> > P.S. We need the Chromium side CL. Fix of the failures will be at blink
side.
> 
> I see. However, as far as I understand, it would be better to fix failures
> before landing some feature.

Sorry, but without the chromium side CL, there is nothing to fix in blink :)

Powered by Google App Engine
This is Rietveld 408576698