Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1128233002: Add mac_tool.py from gyp 0bb67471bca068996e15b56738fa4824dfa19de0 (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
Reviewers:
cdotstout
CC:
mojo-reviews_chromium.org, eseidel
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add mac_tool.py from gyp 0bb67471bca068996e15b56738fa4824dfa19de0 This script is used by the mac build for compiling targets on the host. It comes from the gyp repo, but is a standalone script independent of the rest of gyp. This adds the file in the path that the build files expect it to live in to avoid needing to modify those build rules. R=cstout@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7f2dde3f8109dd376cedaa38e8e5fd94bc240616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -1 line) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A tools/gyp/pylib/gyp/mac_tool.py View 1 chunk +610 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
5 years, 7 months ago (2015-05-06 18:22:11 UTC) #2
cdotstout
lgtm
5 years, 7 months ago (2015-05-06 18:29:21 UTC) #3
jamesr
5 years, 7 months ago (2015-05-06 18:31:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f2dde3f8109dd376cedaa38e8e5fd94bc240616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698