Passing Native Texture backed Video Frame from Renderer to GPU process

content/common/gpu/media/gpu_video_encode_accelerator.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/gpu_video_encode_accelerator.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
@@ skipping 94 matching lines @@
                        initial_bitrate,
                        this);
   input_format_ = input_format;
   input_visible_size_ = input_visible_size;
   SendCreateEncoderReply(init_done_msg, true);
 }
 
 bool GpuVideoEncodeAccelerator::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(GpuVideoEncodeAccelerator, message)
-    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Encode, OnEncode)
+  IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_EncodeSharedMemory,

[mcasas, 2015/06/04 15:20:55]

Indent here and in l.117 to match l.119 etc.
I know, they're unorthodox.

[emircan, 2015/06/04 22:04:40]

Done.

+                      OnEncodeSharedMemory)
+  IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_EncodeNativeTexture,
+                      OnEncodeNativeTexture)
     IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_UseOutputBitstreamBuffer,
                         OnUseOutputBitstreamBuffer)
     IPC_MESSAGE_HANDLER(
         AcceleratedVideoEncoderMsg_RequestEncodingParametersChange,
         OnRequestEncodingParametersChange)
     IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Destroy, OnDestroy)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
@@ skipping 74 matching lines @@
 // static
 scoped_ptr<media::VideoEncodeAccelerator>
 GpuVideoEncodeAccelerator::CreateAndroidVEA() {
   scoped_ptr<media::VideoEncodeAccelerator> encoder;
 #if defined(OS_ANDROID) && defined(ENABLE_WEBRTC)
   encoder.reset(new AndroidVideoEncodeAccelerator());
 #endif
   return encoder.Pass();
 }
 
-void GpuVideoEncodeAccelerator::OnEncode(int32 frame_id,
-                                         base::SharedMemoryHandle buffer_handle,
-                                         uint32 buffer_offset,
-                                         uint32 buffer_size,
-                                         bool force_keyframe) {
+void GpuVideoEncodeAccelerator::OnEncodeSharedMemory(
+    int32 frame_id,
+    base::SharedMemoryHandle buffer_handle,
+    uint32 buffer_offset,
+    uint32 buffer_size,
+    bool force_keyframe) {
   DVLOG(3) << "GpuVideoEncodeAccelerator::OnEncode(): frame_id=" << frame_id

[mcasas, 2015/06/04 15:20:55]

Update the method name. Or better, use __func__

            << ", buffer_size=" << buffer_size
            << ", force_keyframe=" << force_keyframe;
   if (!encoder_)
     return;
   if (frame_id < 0) {
     DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): invalid frame_id="
                 << frame_id;
     NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
     return;
   }
@@ skipping 26 matching lines @@
       media::VideoFrame::WrapExternalSharedMemory(
           input_format_,
           input_coded_size_,
           gfx::Rect(input_visible_size_),
           input_visible_size_,
           shm_memory,
           buffer_size,
           buffer_handle,
           buffer_offset,
           base::TimeDelta());
-  frame->AddDestructionObserver(
-      media::BindToCurrentLoop(
-          base::Bind(&GpuVideoEncodeAccelerator::EncodeFrameFinished,
-                     weak_this_factory_.GetWeakPtr(),
-                     frame_id,
-                     base::Passed(&shm))));
+  frame->AddDestructionObserver(media::BindToCurrentLoop(base::Bind(
+      &GpuVideoEncodeAccelerator::EncodeSharedMemoryFrameFinished,
+      weak_this_factory_.GetWeakPtr(), frame_id, base::Passed(&shm))));
 
   if (!frame.get()) {
     DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): "
                    "could not create VideoFrame for frame_id=" << frame_id;
     NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
     return;
   }
 
   encoder_->Encode(frame, force_keyframe);
 }
 
+void GpuVideoEncodeAccelerator::OnEncodeNativeTexture(
+    int32 frame_id,
+    gpu::MailboxHolder mailbox_holder,
+    bool force_keyframe) {
+  DVLOG(3) << "GpuVideoEncodeAccelerator::OnEncodeNativeTexture(): frame_id="
+           << frame_id << ", force_keyframe=" << force_keyframe;
+  if (!encoder_)
+    return;
+  if (frame_id < 0) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncodeNativeTexture(): "
+                   "invalid frame_id=" << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+  DCHECK(!mailbox_holder.mailbox.IsZero());

[mcasas, 2015/06/04 15:20:56]

nit: pass these DCHECKs to the beginning of the method?

[emircan, 2015/06/04 22:04:40]

Done.

+  DCHECK(mailbox_holder.mailbox.Verify());
+  DCHECK(mailbox_holder.texture_target);
+  DCHECK(mailbox_holder.sync_point);
+
+  scoped_refptr<media::VideoFrame> frame = media::VideoFrame::WrapNativeTexture(
+      mailbox_holder,
+      media::VideoFrame::ReleaseMailboxCB(),
+      input_coded_size_, gfx::Rect(input_visible_size_), input_visible_size_,
+      base::TimeDelta(), true /* allow_overlay */, true /* has_alpha */);
+  frame->AddDestructionObserver(media::BindToCurrentLoop(
+      base::Bind(&GpuVideoEncodeAccelerator::EncodeNativeTextureFrameFinished,
+                 weak_this_factory_.GetWeakPtr(), frame_id)));
+  if (!frame.get()) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncodeNativeTexture(): "
+                   "could not create VideoFrame for frame_id=" << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+
+  encoder_->Encode(frame, force_keyframe);
+}
+
 void GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(
     int32 buffer_id,
     base::SharedMemoryHandle buffer_handle,
     uint32 buffer_size) {
   DVLOG(3) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
               "buffer_id=" << buffer_id
            << ", buffer_size=" << buffer_size;
   if (!encoder_)
     return;
   if (buffer_id < 0) {
@@ skipping 21 matching lines @@
     uint32 bitrate,
     uint32 framerate) {
   DVLOG(2) << "GpuVideoEncodeAccelerator::OnRequestEncodingParametersChange(): "
               "bitrate=" << bitrate
            << ", framerate=" << framerate;
   if (!encoder_)
     return;
   encoder_->RequestEncodingParametersChange(bitrate, framerate);
 }
 
-void GpuVideoEncodeAccelerator::EncodeFrameFinished(
+void GpuVideoEncodeAccelerator::EncodeSharedMemoryFrameFinished(
     int32 frame_id,
     scoped_ptr<base::SharedMemory> shm) {
   Send(new AcceleratedVideoEncoderHostMsg_NotifyInputDone(host_route_id_,
                                                           frame_id));
   // Just let shm fall out of scope.

[mcasas, 2015/06/04 15:20:55]

s/shm/|shm|/

[emircan, 2015/06/04 22:04:41]

Done.

 }
+void GpuVideoEncodeAccelerator::EncodeNativeTextureFrameFinished(
+    int32 frame_id) {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyInputDone(host_route_id_,
+                                                          frame_id));
+}
 
 void GpuVideoEncodeAccelerator::Send(IPC::Message* message) {
   stub_->channel()->Send(message);
 }
 
 void GpuVideoEncodeAccelerator::SendCreateEncoderReply(IPC::Message* message,
                                                        bool succeeded) {
   GpuCommandBufferMsg_CreateVideoEncoder::WriteReplyParams(message, succeeded);
   Send(message);
 }
 
 }  // namespace content