Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 1128203009: Fix link errors with Skia in libui_touch_selection.so (Closed)

Created:
5 years, 7 months ago by joone
Modified:
5 years, 7 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, mohsen, davve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix link errors with Skia in libui_touch_selection.so When building a debug version of Chromium in Linux with component=shared_library build flag, there are link errors as follows: error: undefined reference to 'SkDebugf_FileLine' error: undefined reference to 'SkToS32' BUG=None Committed: https://crrev.com/64b0e3fa8022ac6932b72e2f86784b83ab03139b Cr-Commit-Position: refs/heads/master@{#329745}

Patch Set 1 #

Total comments: 1

Patch Set 2 : GN file was updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/touch_selection/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/touch_selection/ui_touch_selection.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
joone
please take a look at this CL.
5 years, 7 months ago (2015-05-13 20:19:51 UTC) #2
jdduke (slow)
Can you also update BUILD.gn? https://codereview.chromium.org/1128203009/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1128203009/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode45 ui/touch_selection/ui_touch_selection.gyp:45: '../aura/aura.gyp:aura', Can you also ...
5 years, 7 months ago (2015-05-13 20:26:31 UTC) #3
joone
On 2015/05/13 20:26:31, jdduke wrote: > Can you also update BUILD.gn? > > https://codereview.chromium.org/1128203009/diff/1/ui/touch_selection/ui_touch_selection.gyp > ...
5 years, 7 months ago (2015-05-13 20:38:03 UTC) #4
joone
On 2015/05/13 20:38:03, joone wrote: > On 2015/05/13 20:26:31, jdduke wrote: > > Can you ...
5 years, 7 months ago (2015-05-13 21:19:10 UTC) #5
jdduke (slow)
lgtm
5 years, 7 months ago (2015-05-13 21:30:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128203009/20001
5 years, 7 months ago (2015-05-13 21:47:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 00:01:52 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/64b0e3fa8022ac6932b72e2f86784b83ab03139b Cr-Commit-Position: refs/heads/master@{#329745}
5 years, 7 months ago (2015-05-14 00:03:37 UTC) #10
davve
5 years, 7 months ago (2015-05-18 08:03:06 UTC) #11
Message was sent while issue was closed.
Thanks for fixing this, joone!

Have we come any closer to finding out what the culprit was? Is it a clang vs.
gcc issue somehow? I suppose if all component=shared_library builds were affect,
it would have been caught earlier?

Powered by Google App Engine
This is Rietveld 408576698