Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issue 1128203005: Add the IDL and stub implementation for the chrome.passwordsPrivate API. (Closed)

Created:
5 years, 7 months ago by Kyle Horimoto
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the IDL and stub implementation for the chrome.passwordsPrivate API. See https://docs.google.com/document/d/1vapDN-76XS4dLsNRFQP9NMnhDstPAC88vPuKblhgMok/edit?usp=sharing for details. BUG=485227 Committed: https://crrev.com/fb89adeac917aa1d2178f0051acbf823e725b4ca Cr-Commit-Position: refs/heads/master@{#329204}

Patch Set 1 #

Patch Set 2 : Changed "atIndex" functions to take more robust arguments, per rockot@'s request. #

Patch Set 3 : ...and fix typo. #

Patch Set 4 : Regenerated externs. #

Patch Set 5 : Synced. #

Patch Set 6 : Rebase/lint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/api/passwords_private/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/extensions/api/passwords_private/passwords_private_api.h View 1 2 3 4 5 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/passwords_private/passwords_private_api.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/passwords_private.idl View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/closure_compiler/externs/autofill_private.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A third_party/closure_compiler/externs/passwords_private.js View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
Kyle Horimoto
5 years, 7 months ago (2015-05-06 22:56:58 UTC) #2
Mark P
histograms.xml lgtm rubber stamp
5 years, 7 months ago (2015-05-06 22:58:59 UTC) #3
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-05-06 22:59:21 UTC) #4
Tyler Breisacher (Chromium)
"lgtm"
5 years, 7 months ago (2015-05-06 23:17:38 UTC) #5
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-08 18:05:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128203005/40001
5 years, 7 months ago (2015-05-08 22:46:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128203005/60001
5 years, 7 months ago (2015-05-08 22:59:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/74313) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-08 23:38:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128203005/80001
5 years, 7 months ago (2015-05-08 23:55:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128203005/100001
5 years, 7 months ago (2015-05-11 17:16:00 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-11 18:44:58 UTC) #27
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:46:37 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fb89adeac917aa1d2178f0051acbf823e725b4ca
Cr-Commit-Position: refs/heads/master@{#329204}

Powered by Google App Engine
This is Rietveld 408576698