[turbofan] Use FrameStatesBeforeAndAfter to simplify handling of before/after frame states in AstGr…

[turbofan] Use FrameStatesBeforeAndAfter to simplify handling of before/after frame states in AstGraphBuilder.

R=jarin@chromium.org
BUG=

Committed: https://crrev.com/0c80fdc61e79ae3cff89a44c536b268a67956675
Cr-Commit-Position: refs/heads/master@{#28361}

[Jarin, 2015-05-12 08:15:33]

lgtm with a question.

https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:2062:
store_states.ResetBefore(expr->binary_operation()->id());
Can't we make the ResetBefore method private and just record the bailout id
here? (And instantiate store_states after the if statement with the recorded
bailout id.)

[titzer, 2015-05-12 11:54:32]

On 2015/05/12 08:15:33, jarin wrote:
> lgtm with a question.
> 
>
https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-buil...
> File src/compiler/ast-graph-builder.cc (right):
> 
>
https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-buil...
> src/compiler/ast-graph-builder.cc:2062:
> store_states.ResetBefore(expr->binary_operation()->id());
> Can't we make the ResetBefore method private and just record the bailout id
> here? (And instantiate store_states after the if statement with the recorded
> bailout id.)

Done.

[titzer, 2015-05-12 12:10:08]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-05-12 12:10:09]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1128193005/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-05-12 12:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128193005/20001

[commit-bot: I haz the power, 2015-05-12 12:30:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 12:30:52]

Patchset 2 (id:??) landed as
https://crrev.com/0c80fdc61e79ae3cff89a44c536b268a67956675
Cr-Commit-Position: refs/heads/master@{#28361}