Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128193004: Move function prototypes to new doc_utils.h file (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move function prototypes to new doc_utils.h file ... rather than redundantly declaring them in several .cpp files, and hoping that the linker lines things up for you. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/06272311aca7ead4f419b65ca41673f1599218ae

Patch Set 1 #

Patch Set 2 : Add missing file. #

Total comments: 1

Patch Set 3 : Copyright year. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -46 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +3 lines, -22 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A core/src/fpdfdoc/doc_utils.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +3 lines, -22 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review. Mostly cut n paste.
5 years, 7 months ago (2015-05-08 16:48:47 UTC) #2
Lei Zhang
Did you forget to add doc_utils.h to this CL?
5 years, 7 months ago (2015-05-08 17:54:23 UTC) #3
Tom Sepez
On 2015/05/08 17:54:23, Lei Zhang wrote: > Did you forget to add doc_utils.h to this ...
5 years, 7 months ago (2015-05-08 18:30:06 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1128193004/diff/20001/core/src/fpdfdoc/doc_utils.h File core/src/fpdfdoc/doc_utils.h (right): https://codereview.chromium.org/1128193004/diff/20001/core/src/fpdfdoc/doc_utils.h#newcode1 core/src/fpdfdoc/doc_utils.h:1: // Copyright 2014 PDFium Authors. All rights reserved. ...
5 years, 7 months ago (2015-05-08 20:24:39 UTC) #5
Tom Sepez
5 years, 7 months ago (2015-05-08 20:36:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
06272311aca7ead4f419b65ca41673f1599218ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698