Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1128193002: Ignore declarations with out of range numeric values (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ignore declarations with out of range numeric values The spec[1] says: Properties may restrict numeric values to some range. If the value is outside the allowed range, the declaration is invalid and must be ignored. Before this patch numeric values we detect as infinite were converted to 0. With this patch an infinite value causes the declaration to be ignored. This behavior change means the hashless hex color quirk does no longer work with large values. Therefore the two remaining test for this in the quirks spec[2] are fixed. [1] http://dev.w3.org/csswg/css-values-3/#numeric-types [2] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk BUG=439050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195026

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M LayoutTests/css-parser/scientific-notation.html View 1 2 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/scientific-numbers-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/css/script-tests/scientific-numbers.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 7 months ago (2015-05-06 22:58:01 UTC) #2
Timothy Loh
On 2015/05/06 22:58:01, rwlbuis wrote: > PTAL lgtm
5 years, 7 months ago (2015-05-07 01:03:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128193002/40001
5 years, 7 months ago (2015-05-07 01:06:36 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 04:45:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195026

Powered by Google App Engine
This is Rietveld 408576698