Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1128183011: Revert of Add support for backgrounding processes on the Mac (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, pink (ping after 24hrs), Zhenyao Mo, Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for backgrounding processes on the Mac (patchset #21 id:400001 of https://codereview.chromium.org/989703002/) Reason for revert: Speculative; several browser_tests started failing on the Mac 10.9 bots, and this looks like the most likely culprit: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/1929 http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/6014 Original issue's description: > Add support for backgrounding processes on the Mac > > Added process_mac.cc with implementations of IsProcessBackgrounded() and > SetProcessBackgrounded(). > > BUG=460102 TBR=rsesek@chromium.org,gab@chromium.org,asvitkine@chromium.org,avi@chromium.org,kbr@chromium.org,shrike@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460102 Committed: https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9 Cr-Commit-Position: refs/heads/master@{#330294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -198 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process.h View 3 chunks +2 lines, -20 lines 0 comments Download
D base/process/process_mac.cc View 1 chunk +0 lines, -126 lines 0 comments Download
M base/process/process_posix.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M base/process/process_unittest.cc View 3 chunks +2 lines, -24 lines 0 comments Download
M content/browser/child_process_launcher.cc View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Created Revert of Add support for backgrounding processes on the Mac
5 years, 7 months ago (2015-05-17 01:14:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128183011/1
5 years, 7 months ago (2015-05-17 01:14:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 01:15:43 UTC) #3
Nico
I'm afraid the revert worked, but bots went green after being consistently red after the ...
5 years, 7 months ago (2015-05-17 02:31:20 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9 Cr-Commit-Position: refs/heads/master@{#330294}
5 years, 7 months ago (2015-05-18 11:32:13 UTC) #5
shrike
5 years, 7 months ago (2015-05-18 17:29:44 UTC) #6
Message was sent while issue was closed.
On 2015/05/17 02:31:20, Nico wrote:
> I'm afraid the revert worked, but bots went green after being consistently red
> after the original CL landed :-/

Hi thakis,

Sorry to hear that my cl caused bots to fail. When I was committing the change
on Friday I had an issue with one of the bots failing a test. The issue is that
some of the tests end up running in a window while Chrome is not the foreground
app, which causes Chrome to background the renderer. As as result, the renderer
process takes more time to complete its work. The test that was failing was a
case of the task not completed in the expected time. This is for 10.9 and higher
only, of course.

I have some questions:

1. Were the bots that failed separate from the ones that run tests during the
check-in process? I don't know that there are such other bots, but if they were
the check-in bots, is it strange that I could check in my changes OK but those
changes caused problems for subsequent committers?

2. How can I see a complete list of the tests that failed, to start trying to
fix the issues?

3. If I am unable to reproduce the problems at check-in time, is it the case
that I will have to address these bugs as best I can, re-commit my cl, and just
see what happens?

Powered by Google App Engine
This is Rietveld 408576698