Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1128173007: [Effen] remove some redundant styles (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] remove some redundant styles Some of the styles we have aren't really needed, so remove them to make it clearer what we weed to actually support to keep the stocks app running. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/593bccb07a3bac58c1660e0a207bd7389e0deaaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M sky/framework/components/button.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/framework/components/checkbox.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/floating_action_button.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/framework/components/menu_item.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 7 months ago (2015-05-14 17:12:13 UTC) #2
Hixie
5 years, 7 months ago (2015-05-14 17:21:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
593bccb07a3bac58c1660e0a207bd7389e0deaaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698