Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1128173005: Clean up ProfileManager interface.

Created:
5 years, 7 months ago by Bernhard Bauer
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, kalyank, tfarina, yurys, rginda+watch_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src@issue479309
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ProfileManager interface: 1) Don't require passing in the user data directory everywhere. ProfileManager already knows the user data directory, and any place that might want to change it will override the value in the PathService. 2) Remove static helper methods that just forward to the corresponding instance method. In part this is necessary to avoid clashes with instance methods that now don't take a parameter anymore, and it also removes ambiguity about how to call these methods. In many cases, callers already had a ProfileManager anyway, and in addition, in some cases the static method was then called via the instance. BUG=none

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix compile #

Patch Set 4 : moar compile fixes #

Patch Set 5 : sync #

Patch Set 6 : argh #

Patch Set 7 : urgh #

Patch Set 8 : . #

Patch Set 9 : sync #

Patch Set 10 : sync #

Patch Set 11 : fix #

Patch Set 12 : sync #

Patch Set 13 : fix #

Patch Set 14 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -201 lines) Patch
M chrome/browser/android/dev_tools_server.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_discovery_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/dom_distiller/tab_utils_android.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/feedback/show_feedback_page.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/extensions_metrics_provider.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu_actions_desktop.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_android.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +11 lines, -19 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 14 chunks +62 lines, -91 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/desktop_notification_balloon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service_android.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_common.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_win.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128173005/160001
5 years, 7 months ago (2015-05-19 20:40:21 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/54951)
5 years, 7 months ago (2015-05-19 20:46:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128173005/200001
5 years, 7 months ago (2015-05-27 21:58:09 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 22:04:22 UTC) #8
Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

Powered by Google App Engine
This is Rietveld 408576698