Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: ui/keyboard/keyboard_controller_proxy.h

Issue 1128173003: Implements onBoundsChanged event in virtualKeyboardPrivate namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller_proxy.h
diff --git a/ui/keyboard/keyboard_controller_proxy.h b/ui/keyboard/keyboard_controller_proxy.h
index 2c91446460815b39bb4eee56fb7d20ff9295aa4a..f927849eb2e8b25c433c2ebe442458d2d6ed7e2e 100644
--- a/ui/keyboard/keyboard_controller_proxy.h
+++ b/ui/keyboard/keyboard_controller_proxy.h
@@ -31,6 +31,8 @@ class Shadow;
namespace keyboard {
+class KeyboardController;
+
// A proxy used by the KeyboardController to get access to the virtual
// keyboard window.
class KEYBOARD_EXPORT KeyboardControllerProxy : public aura::WindowObserver {
@@ -101,6 +103,11 @@ class KEYBOARD_EXPORT KeyboardControllerProxy : public aura::WindowObserver {
// provide one.
virtual void ReloadKeyboardIfNeeded();
+ // KeyboardController owns KeyboardControllerProxy so KeyboardControllerProxy
+ // or its subclasses should not take ownership of the |controller|.
+ // |controller| can be null when KeyboardController is destroying.
+ virtual void SetController(KeyboardController* controller) {}
+
protected:
// The implementation can choose to setup the WebContents before the virtual
// keyboard page is loaded (e.g. install a WebContentsObserver).
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698