ui/keyboard/keyboard_controller.cc - Issue 1128173003: Implements onBoundsChanged event in virtualKeyboardPrivate namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 1128173003: Implements onBoundsChanged event in virtualKeyboardPrivate namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use SetController(nullptr) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc ('K') | « extensions/common/api/virtual_keyboard_private.json ('k') | ui/keyboard/keyboard_controller_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/keyboard/keyboard_controller.cc

diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc

index b34d42756339cea462020550b63038bc0bd8c947..2801eb478ca96ede0997bc4b80791bba21740896 100644

--- a/ui/keyboard/keyboard_controller.cc

+++ b/ui/keyboard/keyboard_controller.cc

@@ -211,6 +211,7 @@ KeyboardController::KeyboardController(KeyboardControllerProxy* proxy)

input_method_ = proxy_->GetInputMethod();

input_method_->AddObserver(this);

window_bounds_observer_.reset(new WindowBoundsChangeObserver());

+ proxy_->SetController(this);

}

KeyboardController::~KeyboardController() {

@@ -222,6 +223,7 @@ KeyboardController::~KeyboardController() {

if (input_method_)

input_method_->RemoveObserver(this);

ResetWindowInsets();

+ proxy_->SetController(nullptr);

}

// static