Implements onBoundsChanged event in virtualKeyboardPrivate namespace

ui/keyboard/keyboard_controller_proxy.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_
 #define UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/common/media_stream_request.h"
 #include "ui/aura/window_observer.h"
@@ skipping 13 matching lines @@
 }
 namespace ui {
 class InputMethod;
 }
 namespace wm {
 class Shadow;
 }
 
 namespace keyboard {
 
+class KeyboardController;
+
 // A proxy used by the KeyboardController to get access to the virtual
 // keyboard window.
 class KEYBOARD_EXPORT KeyboardControllerProxy : public aura::WindowObserver {
  public:
   class TestApi {
    public:
     explicit TestApi(KeyboardControllerProxy* proxy) : proxy_(proxy) {}
 
     const content::WebContents* keyboard_contents() {
       return proxy_->keyboard_contents_.get();
@@ skipping 50 matching lines @@
   // different. The URL can be different if user switch from password field to
   // any other type input field.
   // At password field, the system virtual keyboard is forced to load even if
   // the current IME provides a customized virtual keyboard. This is needed to
   // prevent IME virtual keyboard logging user's password. Once user switch to
   // other input fields, the virtual keyboard should switch back to the IME
   // provided keyboard, or keep using the system virtual keyboard if IME doesn't
   // provide one.
   virtual void ReloadKeyboardIfNeeded();
 
+  virtual void SetController(KeyboardController* controller);
+
  protected:
   // The implementation can choose to setup the WebContents before the virtual
   // keyboard page is loaded (e.g. install a WebContentsObserver).
   // SetupWebContents() is called right after creating the WebContents, before
   // loading the keyboard page.
   virtual void SetupWebContents(content::WebContents* contents);
 
   // aura::WindowObserver overrides:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
                              const gfx::Rect& new_bounds) override;
   void OnWindowDestroyed(aura::Window* window) override;
 
   content::BrowserContext* browser_context() { return browser_context_; }
+  KeyboardController* keyboard_controller() { return keyboard_controller_; }
 
  private:
   friend class TestApi;
 
   // Loads the web contents for the given |url|.
   void LoadContents(const GURL& url);
 
   // Gets the virtual keyboard URL (either the default URL or IME override URL).
   const GURL& GetVirtualKeyboardUrl();
 
   // The BrowserContext to use for creating the WebContents hosting the
   // keyboard.
   content::BrowserContext* browser_context_;
 
+  KeyboardController* keyboard_controller_;
+

[sadrul, 2015/05/13 16:47:30]

There's no reason for the default impl here to store this, right? The ash impl
can do the work instead.

[bshe, 2015/05/13 18:30:03]

Correct. I have changed the code according to your suggestion.
I didn't make SetController pure virtual to avoid implement them in two other
places. But if you think it is better to make it pure virtual, I will do the
change.

   const GURL default_url_;
 
   scoped_ptr<content::WebContents> keyboard_contents_;
   scoped_ptr<wm::Shadow> shadow_;
 
   DISALLOW_COPY_AND_ASSIGN(KeyboardControllerProxy);
 };
 
 }  // namespace keyboard
 
 #endif  // UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_