Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128163004: ServiceWorker: Add null check in ServiceWorkerContextWrapper::DeleteAndStartOver (Closed)

Created:
5 years, 7 months ago by nhiroki
Modified:
5 years, 7 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Add null check in ServiceWorkerContextWrapper::DeleteAndStartOver BUG=485399 TEST=n/a Committed: https://crrev.com/e7dd319feb17faed689d4ff8f20f0312b9eba5e2 Cr-Commit-Position: refs/heads/master@{#328718}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nhiroki
PTAL, thanks!
5 years, 7 months ago (2015-05-07 04:11:44 UTC) #3
Kunihiko Sakamoto
LGTM
5 years, 7 months ago (2015-05-07 04:13:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128163004/20001
5 years, 7 months ago (2015-05-07 04:14:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-07 05:53:39 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 05:54:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e7dd319feb17faed689d4ff8f20f0312b9eba5e2
Cr-Commit-Position: refs/heads/master@{#328718}

Powered by Google App Engine
This is Rietveld 408576698