Add unit tests to text context

Add unit tests to text context

TBR=bsalomon@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/79dfb2b6b6db7b2e703810d26dbdc90cf3ea40f9

[joshualitt, 2015-05-08 14:18:51]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-05-08 14:18:52]

ptal. Brian for api.

[robertphillips, 2015-05-08 17:12:13]

https://codereview.chromium.org/1128153005/diff/1/include/core/SkPostConfig.h
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1128153005/diff/1/include/core/SkPostConfig.h...
include/core/SkPostConfig.h:376: #ifndef GR_TEST_UTILS
Is this intentional ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext.cpp
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:2214: static bool gInit;
init gContextID to the invalid id and do away with gInit ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:2215: static uint32_t gContextID;
init gTextContext to NULL ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:2224: // We enable distance fields by twiddling a
knob on the paint
Can't we leak a GrAtlasTextContext here if the context changes ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:2234: desc.fSampleCnt = 1;
SkAutoTUnref ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:2258: 
remove "need" ?
Isn't this testing TextBlobs ?

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext.h
File src/gpu/GrAtlasTextContext.h (right):

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.h:345: // TODO this is really ugly.  It'd be much
nicer if positioning could be moved to batch
blarg

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrTextContext.h
File src/gpu/GrTextContext.h (right):

https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrTextContext.h#new...
src/gpu/GrTextContext.h:14: #include "SkDeviceProperties.h"
Death to all spaces!

[joshualitt, 2015-05-08 19:04:51]

Patchset #2 (id:20001) has been deleted

[joshualitt, 2015-05-08 19:13:26]

On 2015/05/08 17:12:13, robertphillips wrote:
> https://codereview.chromium.org/1128153005/diff/1/include/core/SkPostConfig.h
> File include/core/SkPostConfig.h (right):
> 
>
https://codereview.chromium.org/1128153005/diff/1/include/core/SkPostConfig.h...
> include/core/SkPostConfig.h:376: #ifndef GR_TEST_UTILS
> Is this intentional ?
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext.cpp
> File src/gpu/GrAtlasTextContext.cpp (right):
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:2214: static bool gInit;
> init gContextID to the invalid id and do away with gInit ?
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:2215: static uint32_t gContextID;
> init gTextContext to NULL ?
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:2224: // We enable distance fields by twiddling
a
> knob on the paint
> Can't we leak a GrAtlasTextContext here if the context changes ?
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:2234: desc.fSampleCnt = 1;
> SkAutoTUnref ?
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:2258: 
> remove "need" ?
> Isn't this testing TextBlobs ?
> 
> https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext.h
> File src/gpu/GrAtlasTextContext.h (right):
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.h:345: // TODO this is really ugly.  It'd be much
> nicer if positioning could be moved to batch
> blarg
> 
> https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrTextContext.h
> File src/gpu/GrTextContext.h (right):
> 
>
https://codereview.chromium.org/1128153005/diff/1/src/gpu/GrTextContext.h#new...
> src/gpu/GrTextContext.h:14: #include "SkDeviceProperties.h"
> Death to all spaces!

feedback incorporated

[robertphillips, 2015-05-08 19:20:08]

lgtm + a suggestion

https://codereview.chromium.org/1128153005/diff/40001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1128153005/diff/40001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:2219: gContextID = context->uniqueID();
Now that it's initialized to NULL we should just be able to SkDELETE w/o the
guard.

[joshualitt, 2015-05-11 15:31:54]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-11 15:31:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1128153005/#ps160001
(title: "more")

[joshualitt, 2015-05-11 15:32:02]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-05-11 15:52:14]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-11 15:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1128153005/#ps220001
(title: "windows warning")

[commit-bot: I haz the power, 2015-05-11 15:52:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128153005/220001

[commit-bot: I haz the power, 2015-05-11 15:58:14]

Committed patchset #11 (id:220001) as
https://skia.googlesource.com/skia/+/79dfb2b6b6db7b2e703810d26dbdc90cf3ea40f9