chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h - Issue 1128153003: Reland "Don't use RSAPrivateKey in NSS integration code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h

Issue 1128153003: Reland "Don't use RSAPrivateKey in NSS integration code." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc ('k') | chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h

index 354450bada1cb453a8a64a45e77546fbbdcf9816..aea7cc03a24d3c05d5255668372acf487a7aa102 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h

@@ -135,7 +135,9 @@ class OwnerSettingsServiceChromeOS : public ownership::OwnerSettingsService,

// OwnerSettingsService protected interface overrides:

- // Reloads private key from profile's NSS slots, responds via |callback|.

+ // Reloads private key from profile's NSS slots, responds via |callback|. On

+ // success, |private_key| is non-null, but if the private key doesn't exist,

+ // |private_key->key()| may be null.

void ReloadKeypairImpl(const base::Callback<

void(const scoped_refptr<ownership::PublicKey>& public_key,

const scoped_refptr<ownership::PrivateKey>& private_key)>& callback)