Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128143005: MediaDrmBridge: Update ConvertInitDataType(). (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, gunsch
Base URL:
https://chromium.googlesource.com/chromium/src.git@init_data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaDrmBridge: Update ConvertInitDataType(). - Update comment about "cenc" and "webm" support. - Support keyids. BUG=488759 Committed: https://crrev.com/7047d54ccbc2b42383c744b2547d61c35eb24e01 Cr-Commit-Position: refs/heads/master@{#330646}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M media/base/android/media_drm_bridge.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
xhwang
ddorwin: PTAL gunsch: FYI
5 years, 7 months ago (2015-05-19 19:47:54 UTC) #2
ddorwin
lgtm
5 years, 7 months ago (2015-05-19 21:29:13 UTC) #3
ddorwin
https://codereview.chromium.org/1128143005/diff/1/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/1128143005/diff/1/media/base/android/media_drm_bridge.cc#newcode67 media/base/android/media_drm_bridge.cc:67: default: Should we do the conversion for KEYIDS so ...
5 years, 7 months ago (2015-05-19 21:35:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128143005/1
5 years, 7 months ago (2015-05-19 21:35:44 UTC) #6
xhwang
comments addressed
5 years, 7 months ago (2015-05-19 21:44:14 UTC) #8
xhwang
https://codereview.chromium.org/1128143005/diff/1/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/1128143005/diff/1/media/base/android/media_drm_bridge.cc#newcode67 media/base/android/media_drm_bridge.cc:67: default: On 2015/05/19 21:35:24, ddorwin wrote: > Should we ...
5 years, 7 months ago (2015-05-19 21:44:24 UTC) #9
ddorwin
LGTM. You might update the commit message.
5 years, 7 months ago (2015-05-19 21:45:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128143005/20001
5 years, 7 months ago (2015-05-19 21:49:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 22:45:42 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:46:23 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7047d54ccbc2b42383c744b2547d61c35eb24e01
Cr-Commit-Position: refs/heads/master@{#330646}

Powered by Google App Engine
This is Rietveld 408576698