Issue 1128133005: Revert of Implement support for non-scale/translate CTM in image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128133005: Revert of Implement support for non-scale/translate CTM in image filters. (Closed)

Created:
5 years, 7 months ago by reed1

Modified:
5 years, 7 months ago

Reviewers:
Stephen White, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Implement support for non-scale/translate CTM in image filters. (patchset #4 id:60001 of https://codereview.chromium.org/1120043002/) Reason for revert: don't reference layer after its deleted Original issue's description: > Implement support for non-scale/translate CTM in image filters. > > Implemented by extracting out the non-scale/translate components > and applying that post-filter as an SkMatrixImageFilter. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4f12b8bd2cb43daeffa4d1c53120ae94c5ccf486 TBR=robertphillips@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/177cb8498662600e9866e260d52d6a2401ad78a8

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -35 lines)			Patch
	M	include/core/SkCanvas.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	src/core/SkCanvas.cpp	View		7 chunks	+6 lines, -33 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Implement support for non-scale/translate CTM in image filters.

5 years, 7 months ago (2015-05-13 20:59:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128133005/1

5 years, 7 months ago (2015-05-13 20:59:56 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 21:00:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/177cb8498662600e9866e260d52d6a2401ad78a8