Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/machine-operator.h

Issue 1128133003: [turbofan] Make an OptionalOperator for MachineOperatorBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: OPTIONAL macro Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-intrinsic-lowering.cc ('k') | src/compiler/machine-operator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/machine-operator.h
diff --git a/src/compiler/machine-operator.h b/src/compiler/machine-operator.h
index 40a68b3df68d45442ff9d1f903a44f06d6d65683..bf45a71e0122b2d865b953ddeb2506b912a8cd48 100644
--- a/src/compiler/machine-operator.h
+++ b/src/compiler/machine-operator.h
@@ -16,6 +16,20 @@ namespace compiler {
struct MachineOperatorGlobalCache;
class Operator;
+// For operators that are not supported on all platforms.
+class OptionalOperator {
+ public:
+ explicit OptionalOperator(const Operator* op) : op_(op) {}
+
+ bool IsSupported() const { return op_ != nullptr; }
+ const Operator* op() const {
+ DCHECK_NOT_NULL(op_);
+ return op_;
+ }
+
+ private:
+ const Operator* op_;
+};
// Supported write barrier modes.
enum WriteBarrierKind { kNoWriteBarrier, kFullWriteBarrier };
@@ -83,7 +97,10 @@ class MachineOperatorBuilder final : public ZoneObject {
kFloat64RoundTiesAway = 1u << 6,
kInt32DivIsSafe = 1u << 7,
kUint32DivIsSafe = 1u << 8,
- kWord32ShiftIsSafe = 1u << 9
+ kWord32ShiftIsSafe = 1u << 9,
+ kAllOptionalOps = kFloat32Max | kFloat32Min | kFloat64Max | kFloat64Min |
+ kFloat64RoundDown | kFloat64RoundTruncate |
+ kFloat64RoundTiesAway
};
typedef base::Flags<Flag, unsigned> Flags;
@@ -186,16 +203,12 @@ class MachineOperatorBuilder final : public ZoneObject {
const Operator* Float64LessThanOrEqual();
// Floating point min/max complying to IEEE 754 (single-precision).
- const Operator* Float32Max();
- const Operator* Float32Min();
- bool HasFloat32Max() { return flags_ & kFloat32Max; }
- bool HasFloat32Min() { return flags_ & kFloat32Min; }
+ const OptionalOperator Float32Max();
+ const OptionalOperator Float32Min();
// Floating point min/max complying to IEEE 754 (double-precision).
- const Operator* Float64Max();
- const Operator* Float64Min();
- bool HasFloat64Max() { return flags_ & kFloat64Max; }
- bool HasFloat64Min() { return flags_ & kFloat64Min; }
+ const OptionalOperator Float64Max();
+ const OptionalOperator Float64Min();
// Floating point abs complying to IEEE 754 (single-precision).
const Operator* Float32Abs();
@@ -204,12 +217,9 @@ class MachineOperatorBuilder final : public ZoneObject {
const Operator* Float64Abs();
// Floating point rounding.
- const Operator* Float64RoundDown();
- const Operator* Float64RoundTruncate();
- const Operator* Float64RoundTiesAway();
- bool HasFloat64RoundDown() { return flags_ & kFloat64RoundDown; }
- bool HasFloat64RoundTruncate() { return flags_ & kFloat64RoundTruncate; }
- bool HasFloat64RoundTiesAway() { return flags_ & kFloat64RoundTiesAway; }
+ const OptionalOperator Float64RoundDown();
+ const OptionalOperator Float64RoundTruncate();
+ const OptionalOperator Float64RoundTiesAway();
// Floating point bit representation.
const Operator* Float64ExtractLowWord32();
« no previous file with comments | « src/compiler/js-intrinsic-lowering.cc ('k') | src/compiler/machine-operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698